Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc

Issue 2182883002: Permissions: Rename PermissionBubbleView to PermissionPromptInterface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig@ review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
similarity index 78%
rename from chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc
rename to chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
index 43ddc952b826c5fd39df2f2e0dc587670f7f32ba..fd06d0ec3a5a83a5941d99888a23cd5e1bc1b8fa 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view_views.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl_views.cc
@@ -10,11 +10,11 @@
#include "chrome/browser/ui/views/frame/top_container_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/views/location_bar/location_icon_view.h"
-#include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
+#include "chrome/browser/ui/views/website_settings/permission_prompt_impl.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/vector2d.h"
-// The Views browser implementation of PermissionBubbleViewViews'
+// The Views browser implementation of PermissionPromptImpl's
// anchor methods. Views browsers have a native View to anchor the bubble to,
// which these functions provide.
@@ -22,7 +22,7 @@
// fullscreen mode.
const int kFullscreenLeftMargin = 40;
-views::View* PermissionBubbleViewViews::GetAnchorView() {
+views::View* PermissionPromptImpl::GetAnchorView() {
BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
if (browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR))
@@ -32,7 +32,7 @@ views::View* PermissionBubbleViewViews::GetAnchorView() {
return nullptr;
}
-gfx::Point PermissionBubbleViewViews::GetAnchorPoint() {
+gfx::Point PermissionPromptImpl::GetAnchorPoint() {
BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser_);
// Get position in view (taking RTL displays into account).
int x_within_browser_view =
@@ -43,12 +43,11 @@ gfx::Point PermissionBubbleViewViews::GetAnchorPoint() {
return browser_view_origin + gfx::Vector2d(x_within_browser_view, 0);
}
-views::BubbleBorder::Arrow PermissionBubbleViewViews::GetAnchorArrow() {
+views::BubbleBorder::Arrow PermissionPromptImpl::GetAnchorArrow() {
return views::BubbleBorder::TOP_LEFT;
}
// static
-std::unique_ptr<PermissionBubbleView> PermissionBubbleView::Create(
- Browser* browser) {
- return base::WrapUnique(new PermissionBubbleViewViews(browser));
+std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(Browser* browser) {
+ return base::WrapUnique(new PermissionPromptImpl(browser));
}

Powered by Google App Engine
This is Rietveld 408576698