chrome/browser/permissions/permission_request_manager.cc - Issue 2182883002: Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_manager.cc

Issue 2182883002: Permissions: Rename PermissionBubbleView to PermissionPromptInterface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thestig@ review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_request_manager.h ('k') | chrome/browser/permissions/permission_request_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_request_manager.cc

diff --git a/chrome/browser/permissions/permission_request_manager.cc b/chrome/browser/permissions/permission_request_manager.cc

index 03b55f0b0b25ddf70c3b229f35d80877c1c1f4ed..e4d6e513bbf493801b44f5f0376f81adaf75c238 100644

--- a/chrome/browser/permissions/permission_request_manager.cc

+++ b/chrome/browser/permissions/permission_request_manager.cc

@@ -79,7 +79,7 @@ PermissionRequestManager::PermissionRequestManager(

content::WebContents* web_contents)

: content::WebContentsObserver(web_contents),

#if !defined(OS_ANDROID) // No bubbles in android tests.

- view_factory_(base::Bind(&PermissionBubbleView::Create)),

+ view_factory_(base::Bind(&PermissionPrompt::Create)),

#endif

view_(nullptr),

main_frame_has_fully_loaded_(false),