MD WebUI: rework how clearing search works

MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7638d4b996143a2e38869215426720de854dd818
Cr-Commit-Position: refs/heads/master@{#407836}

[Dan Beam, 2016-07-26 01:12:00]

Description was changed from

==========
MD WebUI: only clear search text when clicking (X) in <cr-search-field>

Previously, when clicking (X) to clear search text, the search field
closed / hide its UI. It should just clear the text, as it says.

Pressing Esc should continue to clear+close completely, though.

R=tsergeant@chromium.org
BUG=611315
==========

to

==========
MD WebUI: only clear search text when clicking (X) in <cr-search-field>

Previously, when clicking (X) to clear search text, the search field
closed / hide its UI. It should just clear the text, as it says.

Pressing Esc should continue to clear+close completely, though.

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-26 01:12:59]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:13:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 01:16:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 01:16:03]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[Dan Beam, 2016-07-26 01:20:42]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:21:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-26 01:32:57]

lgtm with a little behaviour suggestion.

https://codereview.chromium.org/2182853002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2182853002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:12:
this.setValue('');
Does this refocus the search field after it is cleared? Seems like that might be
useful behavior.

[Dan Beam, 2016-07-26 02:04:47]

i'm also hiding the (x) when there's nothing to clear

https://codereview.chromium.org/2182853002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2182853002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:12:
this.setValue('');
On 2016/07/26 01:32:57, tsergeant wrote:
> Does this refocus the search field after it is cleared? Seems like that might
be
> useful behavior.

Done.

[Dan Beam, 2016-07-26 02:06:56]

Description was changed from

==========
MD WebUI: only clear search text when clicking (X) in <cr-search-field>

Previously, when clicking (X) to clear search text, the search field
closed / hide its UI. It should just clear the text, as it says.

Pressing Esc should continue to clear+close completely, though.

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-26 04:19:29]

still lgtm

https://codereview.chromium.org/2182853002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2182853002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:11: value_: {
Nit: 

value_: String

[Dan Beam, 2016-07-26 04:46:21]

https://codereview.chromium.org/2182853002/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2182853002/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:11: value_: {
On 2016/07/26 04:19:29, tsergeant wrote:
> Nit: 
> 
> value_: String

Done.

[Dan Beam, 2016-07-26 04:46:39]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-07-26 04:46:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2182853002/#ps60001
(title: "tsergeant@ review")

[commit-bot: I haz the power, 2016-07-26 04:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 05:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 05:34:45]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Dan Beam, 2016-07-26 16:39:45]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:40:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:10:30]

Description was changed from

==========
MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-26 17:10:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 17:13:50]

Description was changed from

==========
MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: rework how clearing search works

Previously, when clicking (X) to clear search text, the search field
closed / hid its UI. It should just clear the text, as it says.
Pressing Esc should continue to clear+close completely, though.

Additionally, we should only show (x) when there's text to hide.
We should also re-focus the search when (x) is clicked (otherwise
focus gets dropped).

R=tsergeant@chromium.org
BUG=611315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7638d4b996143a2e38869215426720de854dd818
Cr-Commit-Position: refs/heads/master@{#407836}
==========

[commit-bot: I haz the power, 2016-07-26 17:13:51]

Patchset 4 (id:??) landed as
https://crrev.com/7638d4b996143a2e38869215426720de854dd818
Cr-Commit-Position: refs/heads/master@{#407836}