ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html - Issue 2182853002: MD WebUI: rework how clearing search works

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html

Issue 2182853002: MD WebUI: rework how clearing search works (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tsergeant@ review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_downloads/vulcanized.html ('k') | ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field_behavior.html">	1 <link rel="import" href="chrome://resources/cr_elements/cr_search_field/cr_searc h_field_behavior.html">

2 <link rel="import" href="chrome://resources/cr_elements/icons.html">	2 <link rel="import" href="chrome://resources/cr_elements/icons.html">

3 <link rel="import" href="chrome://resources/html/assert.html">	3 <link rel="import" href="chrome://resources/html/assert.html">

4 <link rel="import" href="chrome://resources/html/polymer.html">	4 <link rel="import" href="chrome://resources/html/polymer.html">

5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">

6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">

8	8

9 <dom-module id="cr-search-field">	9 <dom-module id="cr-search-field">

10 <template>	10 <template>

11 <paper-icon-button icon="cr:search" id="searchButton"	11 <paper-icon-button icon="cr:search" id="searchButton"

12 disabled$="[[showingSearch]]" title="[[label]]"	12 disabled$="[[showingSearch]]" title="[[label]]"

13 on-click="toggleShowingSearch_"></paper-icon-button>	13 on-tap="toggleShowingSearch_"></paper-icon-button>

14 <paper-input-container id="searchTerm" on-search="onSearchTermSearch"	14 <paper-input-container id="searchTerm" on-search="onSearchTermSearch"

15 on-keydown="onSearchTermKeydown" hidden$="[[!showingSearch]]"	15 on-keydown="onSearchTermKeydown" hidden$="[[!showingSearch]]"

16 no-label-float>	16 no-label-float>

17 <input is="iron-input" id="searchInput" type="search"	17 <input is="iron-input" id="searchInput" type="search"

18 placeholder="[[label]]" incremental>	18 bind-value="{{value_}}" placeholder="[[label]]" incremental>

19 <paper-icon-button icon="cr:cancel" id="clearSearch"	19 <template is="dom-if" if="[[value_]]">

20 on-click="toggleShowingSearch_" title="[[clearLabel]]"	20 <paper-icon-button icon="cr:cancel" on-tap="clearSearch_"

21 hidden$="[[!showingSearch]]"></paper-icon-button>	21 title="[[clearLabel]]" hidden$="[[!showingSearch]]">

	22 </paper-icon-button>

	23 </template>

22 </paper-input-container>	24 </paper-input-container>

23 </template>	25 </template>

24 <link rel="import" type="css" href="cr_search_field.css">	26 <link rel="import" type="css" href="cr_search_field.css">

25 <script src="cr_search_field.js"></script>	27 <script src="cr_search_field.js"></script>

26 </dom-module>	28 </dom-module>

OLD	NEW