MD WebUI: Remove local DOM access from CrSearchFieldBehavior

MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d558a65f1cfc92d007563789815078ef4e50853
Cr-Commit-Position: refs/heads/master@{#407975}

[tsergeant, 2016-07-26 05:27:37]

Description was changed from

==========
MD WebUI: Add getSearchInput to CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
==========

to

==========
MD WebUI: Add getSearchInput to CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-26 05:31:41]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 05:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-26 05:47:21]

Description was changed from

==========
MD WebUI: Add getSearchInput to CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-26 05:47:33]

Description was changed from

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-26 05:47:56]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2016-07-26 05:47:56]

Here we go, PTAL

[commit-bot: I haz the power, 2016-07-26 07:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 07:01:04]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-07-26 16:42:02]

lgtm

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:14: /**
@return {!HTMLInputElement} */
does /** @override */ work?

[tsergeant, 2016-07-26 23:32:49]

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:14: /**
@return {!HTMLInputElement} */
On 2016/07/26 16:42:02, Dan Beam wrote:
> does /** @override */ work?

No, Closure complains about overriding something that doesn't exist.

[Dan Beam, 2016-07-26 23:36:54]

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js (right):

https://codereview.chromium.org/2180843006/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js:14: /**
@return {!HTMLInputElement} */
On 2016/07/26 23:32:49, tsergeant wrote:
> On 2016/07/26 16:42:02, Dan Beam wrote:
> > does /** @override */ work?
> 
> No, Closure complains about overriding something that doesn't exist.

bummer

[tsergeant, 2016-07-26 23:40:16]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:40:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 23:45:31]

Description was changed from

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-26 23:45:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 23:49:29]

Description was changed from

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Remove local DOM access from CrSearchFieldBehavior

This decouples the behavior implementation from the HTML layout of the
elements which use it. Also moves isSearchFocused to the
cr-toolbar-search-field element, as it does not need to be in the
generic behavior.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d558a65f1cfc92d007563789815078ef4e50853
Cr-Commit-Position: refs/heads/master@{#407975}
==========

[commit-bot: I haz the power, 2016-07-26 23:49:31]

Patchset 2 (id:??) landed as
https://crrev.com/2d558a65f1cfc92d007563789815078ef4e50853
Cr-Commit-Position: refs/heads/master@{#407975}