chrome/browser/resources/md_downloads/vulcanized.html - Issue 2182853002: MD WebUI: rework how clearing search works

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/vulcanized.html

Issue 2182853002: MD WebUI: rework how clearing search works (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tsergeant@ review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_downloads/crisper.js ('k') | ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_downloads/vulcanized.html

diff --git a/chrome/browser/resources/md_downloads/vulcanized.html b/chrome/browser/resources/md_downloads/vulcanized.html

index e341ce8c18d269c2de2fa0337630d67d48280032..7acac6e3379bf13e34470915b836f64c19de6aa2 100644

--- a/chrome/browser/resources/md_downloads/vulcanized.html

+++ b/chrome/browser/resources/md_downloads/vulcanized.html

@@ -2487,10 +2487,13 @@ paper-icon-button {

}

</style>

- <paper-icon-button icon="cr:search" id="searchButton" disabled$="[[showingSearch]]" title="[[label]]" on-click="toggleShowingSearch_"></paper-icon-button>

+ <paper-icon-button icon="cr:search" id="searchButton" disabled$="[[showingSearch]]" title="[[label]]" on-tap="toggleShowingSearch_"></paper-icon-button>

<paper-input-container id="searchTerm" on-search="onSearchTermSearch" on-keydown="onSearchTermKeydown" hidden$="[[!showingSearch]]" no-label-float="">

- <input is="iron-input" id="searchInput" type="search" placeholder="[[label]]" incremental="">

- <paper-icon-button icon="cr:cancel" id="clearSearch" on-click="toggleShowingSearch_" title="[[clearLabel]]" hidden$="[[!showingSearch]]"></paper-icon-button>

+ <input is="iron-input" id="searchInput" type="search" bind-value="{{value_}}" placeholder="[[label]]" incremental="">

+ <template is="dom-if" if="[[value_]]">

+ <paper-icon-button icon="cr:cancel" on-tap="clearSearch_" title="[[clearLabel]]" hidden$="[[!showingSearch]]">

+ </paper-icon-button>

+ </template>

</paper-input-container>

</template>