Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2182783004: Add test configs for instanced rendering (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add test configs for instanced rendering Adds the following configs and enables them on select bots: glinst, glinst4, glinstdit4, glinst16, glinstdit16, esinst, esinst4, esinstdit4 Makes general changes to GrContextOptions, GrCaps, etc. to facilitate this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182783004 Committed: https://skia.googlesource.com/skia/+/e0d362929d6569e8737d80dead791c640390e819

Patch Set 1 #

Patch Set 2 : Add dedicated configs for instanced rendering #

Patch Set 3 : Add test configs for instanced rendering #

Patch Set 4 : Add test configs for instanced rendering #

Patch Set 5 : rebase #

Patch Set 6 : rebase + precision fix #

Patch Set 7 : Add test configs for instanced rendering #

Patch Set 8 : Add test configs for instanced rendering #

Patch Set 9 : Add test configs for instanced rendering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+881 lines, -126 lines) Patch
M bench/nanobench.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M dm/DM.cpp View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/GrCaps.h View 2 chunks +18 lines, -0 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrCaps.cpp View 1 2 3 4 5 6 7 3 chunks +18 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 6 chunks +12 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/instanced/GLInstancedRendering.h View 3 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/instanced/GLInstancedRendering.cpp View 1 chunk +9 lines, -15 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.h View 3 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 1 2 3 4 5 4 chunks +18 lines, -22 lines 0 comments Download
M src/gpu/instanced/InstancedRendering.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/instanced/InstancedRendering.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M tests/TestConfigParsing.cpp View 1 2 3 4 5 6 3 chunks +38 lines, -3 lines 0 comments Download
M tools/dm_flags.json View 1 2 3 4 5 6 3 chunks +506 lines, -1 line 0 comments Download
M tools/dm_flags.py View 1 2 3 4 5 6 3 chunks +12 lines, -0 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 2 3 4 5 6 7 chunks +40 lines, -25 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gpu/GrContextFactory.cpp View 8 4 chunks +15 lines, -3 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tools/nanobench_flags.json View 1 2 3 4 5 6 7 3 chunks +96 lines, -0 lines 0 comments Download
M tools/nanobench_flags.py View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
csmartdalton
4 years, 4 months ago (2016-07-28 22:25:57 UTC) #6
csmartdalton
As long as the perf bots do ok this is ready for review.
4 years, 4 months ago (2016-07-28 22:43:58 UTC) #7
bsalomon
lgtm
4 years, 4 months ago (2016-07-29 13:57:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182783004/160001
4 years, 4 months ago (2016-07-29 14:33:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:14:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/e0d362929d6569e8737d80dead791c640390e819

Powered by Google App Engine
This is Rietveld 408576698