Add a check that the Chromedriver prebuilt name is expected.

Add a check that the Chromedriver prebuilt name is expected.

There was a recent issue where the gsutil_download.DownloadLatest
function was grabbing a chromedriver prebuilt named rNone.zip.
This CL ensures that the prebuilt downloaded matches the expected
format.

BUG=627633
Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28

[mikecase (-- gone --), 2016-07-25 18:28:13]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, samuong@chromium.org

[mikecase (-- gone --), 2016-07-25 18:28:14]

Fix to prevent the recipe from downloading something like rNone.zip again like
it did.

This recipe was using gsutil.download_latest which never actually returned the
name of the file being downloaded. It would rename it to what you passed in for
the 'destination' argument. Therefore, I had to swap around the implementation a
little bit to add the check I wanted to.

PTAL

[jbudorick, 2016-07-25 18:37:01]

On 2016/07/25 18:28:14, mikecase wrote:
> Fix to prevent the recipe from downloading something like rNone.zip again like
> it did.
> 
> This recipe was using gsutil.download_latest which never actually returned the
> name of the file being downloaded. It would rename it to what you passed in
for
> the 'destination' argument. Therefore, I had to swap around the implementation
a
> little bit to add the check I wanted to.
> 
> PTAL

This seems like the wrong fix... why did rNone get in there in the first place?

[samuong, 2016-07-25 18:40:45]

I'm not sure how rNone.zip got there, but it would've been uploaded by the
desktop bots, which will be converted soon.

Rather than filtering out rNone.zip, can we fail with an error if we find it?
I'm thinking we could continue to use gsutil.download_latest_file() and pass
unzipped_dir as the destination instead of zipfile, and then check the filename
after we download.

[mikecase (-- gone --), 2016-07-26 01:15:58]

On 2016/07/25 at 18:40:45, samuong wrote:
> I'm not sure how rNone.zip got there, but it would've been uploaded by the
desktop bots, which will be converted soon.
> 
> Rather than filtering out rNone.zip, can we fail with an error if we find it?
I'm thinking we could continue to use gsutil.download_latest_file() and pass
unzipped_dir as the destination instead of zipfile, and then check the filename
after we download.

I agree with both of you. When the desktop bots get converted to recipes we can
ensure things like rNone.zip are never uploaded. In the meantime, if it looks
alright, I implemented Sam's suggestion. I do a listdir on the directory to get
the file name and verify it looks good. If not, I raise a StepFailure (see the
new Android_ChromeDriver_unexpected_prebuilt.json expectation file)

[samuong, 2016-07-26 02:36:06]

lgtm, although i'm not an owner. john, wdyt?

[jbudorick, 2016-07-26 03:01:50]

lgtm

[mikecase (-- gone --), 2016-07-26 15:15:31]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-07-26 15:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 15:19:11]

Description was changed from

==========
Add a check that the Chromedriver prebuilt name is expected.

There was a recent issue where the gsutil_download.DownloadLatest
function was grabbing a chromedriver prebuilt named rNone.zip.
This CL ensures that the prebuilt downloaded matches the expected
format.

BUG=627633
==========

to

==========
Add a check that the Chromedriver prebuilt name is expected.

There was a recent issue where the gsutil_download.DownloadLatest
function was grabbing a chromedriver prebuilt named rNone.zip.
This CL ensures that the prebuilt downloaded matches the expected
format.

BUG=627633

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/fa851a0dcddcbcec44c2...
==========

[commit-bot: I haz the power, 2016-07-26 15:19:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/fa851a0dcddcbcec44c2...