scripts/slave/recipe_modules/chromedriver/example.py - Issue 2181693004: Add a check that the Chromedriver prebuilt name is expected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromedriver/example.py

Issue 2181693004: Add a check that the Chromedriver prebuilt name is expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Changed to Sam's impl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromedriver/api.py ('k') | scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromedriver/example.py

diff --git a/scripts/slave/recipe_modules/chromedriver/example.py b/scripts/slave/recipe_modules/chromedriver/example.py

index 4052550e54c979793a21e95220a11505cb3664b6..397377dd0120e01c4b53f624f37cf67d8437cdc3 100644

--- a/scripts/slave/recipe_modules/chromedriver/example.py

+++ b/scripts/slave/recipe_modules/chromedriver/example.py

@@ -13,6 +13,7 @@ DEPS = [

'commit_position',

'depot_tools/bot_update',

'depot_tools/gclient',

+ 'recipe_engine/json',

'recipe_engine/platform',

'recipe_engine/properties',

'recipe_engine/raw_io',

@@ -106,3 +107,15 @@ def GenTests(api):

got_revision_cp='refs/heads/master@{#3333333333}') +

api.step_data(

'Download Test Results Log.gsutil download results log', retcode=1))

+ yield (

+ api.test('%s_unexpected_prebuilt' % sanitize('Android ChromeDriver')) +

+ api.properties.generic(

+ buildername='Android ChromeDriver Tests Example',

+ slavename='slavename') +

+ api.properties(

+ parent_build_archive_url='gs://test-domain/test-archive.zip',

+ got_revision_cp='refs/heads/master@{#3333333333}') +

+ api.step_data(

+ 'Download Prebuilts.listdir get prebuilt filename',

+ api.json.output(['rNone.zip'])))