Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json

Issue 2181693004: Add a check that the Chromedriver prebuilt name is expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Changed to Sam's impl Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
diff --git a/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json b/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
index 4ab5053046b151528de9abd3a5a72e31bfefe470..2f2d3b8656b18aaed43a57d5d0e82e2d1d9b9bdd 100644
--- a/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
+++ b/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
@@ -454,7 +454,7 @@
"--url",
"gs://chromedriver-data/prebuilts",
"--dst",
- "[TMP_BASE]/prebuilt_tmp_1/build.zip",
+ "[TMP_BASE]/prebuilt_tmp_1",
"--partial-name",
"gs://chromedriver-data/prebuilts/r"
],
@@ -468,10 +468,33 @@
"cmd": [
"python",
"-u",
+ "\nimport json, os, sys\nif os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):\n with open(sys.argv[2], 'w') as f:\n json.dump(os.listdir(sys.argv[1]), f)\n",
+ "[TMP_BASE]/prebuilt_tmp_1",
+ "/path/to/tmp/json"
+ ],
+ "name": "Download Prebuilts.listdir get prebuilt filename",
+ "~followup_annotations": [
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_LOG_LINE@json.output@[@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"r111111.zip\"@@@",
+ "@@@STEP_LOG_LINE@json.output@]@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import json, os, sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ with open(sys.argv[2], 'w') as f:@@@",
+ "@@@STEP_LOG_LINE@python.inline@ json.dump(os.listdir(sys.argv[1]), f)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"RECIPE_MODULE[build::zip]/resources/unzip.py"
],
"name": "Download Prebuilts.unzip prebuilt",
- "stdin": "{\"output\": \"[TMP_BASE]/prebuilt_tmp_1/unzipped\", \"zip_file\": \"[TMP_BASE]/prebuilt_tmp_1/build.zip\"}",
+ "stdin": "{\"output\": \"[TMP_BASE]/prebuilt_tmp_1/unzipped\", \"zip_file\": \"[TMP_BASE]/prebuilt_tmp_1/r111111.zip\"}",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@"
]

Powered by Google App Engine
This is Rietveld 408576698