scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json - Issue 2181693004: Add a check that the Chromedriver prebuilt name is expected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json

Issue 2181693004: Add a check that the Chromedriver prebuilt name is expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Changed to Sam's impl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json ('k') | scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json

diff --git a/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json b/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json

index 493653630a6f77287556520c0438b90644a04912..1fd48b0b133c0636acb04c0058ea1f4f13a36b78 100644

--- a/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json

+++ b/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json

@@ -116,7 +116,7 @@

"--url",

"gs://chromedriver-data/prebuilts",

"--dst",

- "[TMP_BASE]/prebuilt_tmp_1/build.zip",

+ "[TMP_BASE]/prebuilt_tmp_1",

"--partial-name",

"gs://chromedriver-data/prebuilts/r"

@@ -130,10 +130,33 @@

"cmd": [

"python",

"-u",

+ "\nimport json, os, sys\nif os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):\n with open(sys.argv[2], 'w') as f:\n json.dump(os.listdir(sys.argv[1]), f)\n",

+ "[TMP_BASE]/prebuilt_tmp_1",

+ "/path/to/tmp/json"

+ ],

+ "name": "Download Prebuilts.listdir get prebuilt filename",

+ "~followup_annotations": [

+ "@@@STEP_NEST_LEVEL@1@@@",

+ "@@@STEP_LOG_LINE@json.output@[@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"r111111.zip\"@@@",

+ "@@@STEP_LOG_LINE@json.output@]@@@",

+ "@@@STEP_LOG_END@json.output@@@",

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import json, os, sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):@@@",

+ "@@@STEP_LOG_LINE@python.inline@ with open(sys.argv[2], 'w') as f:@@@",

+ "@@@STEP_LOG_LINE@python.inline@ json.dump(os.listdir(sys.argv[1]), f)@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"RECIPE_MODULE[build::zip]/resources/unzip.py"

"name": "Download Prebuilts.unzip prebuilt",

- "stdin": "{\"output\": \"[TMP_BASE]/prebuilt_tmp_1/unzipped\", \"zip_file\": \"[TMP_BASE]/prebuilt_tmp_1/build.zip\"}",

+ "stdin": "{\"output\": \"[TMP_BASE]/prebuilt_tmp_1/unzipped\", \"zip_file\": \"[TMP_BASE]/prebuilt_tmp_1/r111111.zip\"}",

"~followup_annotations": [

"@@@STEP_NEST_LEVEL@1@@@"

]