Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2180293002: Remove the print option from the menu and make it a share destination. (Closed)

Created:
4 years, 4 months ago by Ted C
Modified:
4 years, 4 months ago
Reviewers:
Theresa
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the print option from the menu and make it a share destination. BUG=629642 Committed: https://crrev.com/710a8ec6580cdabd681a20d19f61851cf1976e15 Cr-Commit-Position: refs/heads/master@{#408280}

Patch Set 1 #

Patch Set 2 : Add proper icons #

Total comments: 1

Patch Set 3 : Fix review comment and pass a task ID explicitly to work on nexus (NEW_TASK) shares #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -28 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/print.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/print.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/print.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/print.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/print.png View 1 Binary file 0 comments Download
M chrome/android/java/res/menu/main_menu.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/res/values/ids.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 1 2 11 chunks +21 lines, -13 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ted C
PTAL
4 years, 4 months ago (2016-07-26 17:03:35 UTC) #2
Theresa
lgtm https://codereview.chromium.org/2180293002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java File chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java (right): https://codereview.chromium.org/2180293002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java#newcode51 chrome/android/java/src/org/chromium/chrome/browser/printing/PrintShareActivity.java:51: || newState == ActivityState.RESUMED) { This should only ...
4 years, 4 months ago (2016-07-26 18:23:12 UTC) #3
Ted C
Switched to passing an explicit task ID. Can you take a quick pass to make ...
4 years, 4 months ago (2016-07-26 21:38:12 UTC) #4
Theresa
lgtm still
4 years, 4 months ago (2016-07-27 22:32:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180293002/60001
4 years, 4 months ago (2016-07-27 22:52:28 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 23:53:01 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 23:56:43 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/710a8ec6580cdabd681a20d19f61851cf1976e15
Cr-Commit-Position: refs/heads/master@{#408280}

Powered by Google App Engine
This is Rietveld 408576698