Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: chrome/android/java/res/menu/main_menu.xml

Issue 2180293002: Remove the print option from the menu and make it a share destination. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <menu xmlns:android="http://schemas.android.com/apk/res/android"> 6 <menu xmlns:android="http://schemas.android.com/apk/res/android">
7 <!-- These menu items are common to tablet and phone. --> 7 <!-- These menu items are common to tablet and phone. -->
8 <group android:id="@+id/PAGE_MENU" 8 <group android:id="@+id/PAGE_MENU"
9 android:visible="false"> 9 android:visible="false">
10 <item android:id="@+id/icon_row_menu_id" 10 <item android:id="@+id/icon_row_menu_id"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 android:title="@string/menu_downloads" /> 43 android:title="@string/menu_downloads" />
44 <item android:id="@+id/share_row_menu_id" 44 <item android:id="@+id/share_row_menu_id"
45 android:title="@null"> 45 android:title="@null">
46 <menu> 46 <menu>
47 <item android:id="@+id/share_menu_id" 47 <item android:id="@+id/share_menu_id"
48 android:title="@string/menu_share_page"/> 48 android:title="@string/menu_share_page"/>
49 <item android:id="@+id/direct_share_menu_id" 49 <item android:id="@+id/direct_share_menu_id"
50 android:title="@null" /> 50 android:title="@null" />
51 </menu> 51 </menu>
52 </item> 52 </item>
53 <item android:id="@+id/print_id"
54 android:title="@string/menu_print" />
55 <item android:id="@+id/find_in_page_id" 53 <item android:id="@+id/find_in_page_id"
56 android:title="@string/menu_find_in_page" /> 54 android:title="@string/menu_find_in_page" />
57 <item android:id="@+id/add_to_homescreen_id" 55 <item android:id="@+id/add_to_homescreen_id"
58 android:title="@string/menu_add_to_homescreen" /> 56 android:title="@string/menu_add_to_homescreen" />
59 <item android:id="@+id/request_desktop_site_id" 57 <item android:id="@+id/request_desktop_site_id"
60 android:title="@string/menu_request_desktop_site" 58 android:title="@string/menu_request_desktop_site"
61 android:checkable="true" 59 android:checkable="true"
62 android:icon="?android:attr/listChoiceIndicatorMultiple" /> 60 android:icon="?android:attr/listChoiceIndicatorMultiple" />
63 <item android:id="@+id/reader_mode_prefs_id" 61 <item android:id="@+id/reader_mode_prefs_id"
64 android:title="@string/menu_reader_mode_prefs" 62 android:title="@string/menu_reader_mode_prefs"
(...skipping 24 matching lines...) Expand all
89 android:visible="false"> 87 android:visible="false">
90 <item android:id="@id/new_tab_menu_id" 88 <item android:id="@id/new_tab_menu_id"
91 android:title="@string/menu_new_tab" /> 89 android:title="@string/menu_new_tab" />
92 <item android:id="@id/new_incognito_tab_menu_id" 90 <item android:id="@id/new_incognito_tab_menu_id"
93 android:title="@string/menu_new_incognito_tab" /> 91 android:title="@string/menu_new_incognito_tab" />
94 <item android:id="@id/preferences_id" 92 <item android:id="@id/preferences_id"
95 android:title="@string/menu_preferences" /> 93 android:title="@string/menu_preferences" />
96 </group> 94 </group>
97 </menu> 95 </menu>
98 96
OLDNEW
« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/print.png ('k') | chrome/android/java/res/values/ids.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698