Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2179713004: Deprecate FLAGS_quic_always_write_queued_retransmissions. (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@128171703
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FLAGS_quic_always_write_queued_retransmissions. Merge internal change: 128178269 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -175 lines) Patch
M net/quic/quic_connection.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +4 lines, -45 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_multipath_sent_packet_manager.h View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/quic_multipath_sent_packet_manager.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M net/quic/quic_multipath_sent_packet_manager_test.cc View 5 chunks +6 lines, -32 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M net/quic/quic_sent_packet_manager_interface.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2182723002 Patch 1

Dependent Patchsets:

Issue 2181813002 Patch 1

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years, 5 months ago (2016-07-25 22:14:46 UTC) #2
Zhongyi Shi
4 years, 5 months ago (2016-07-25 23:04:57 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698