Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 2179713004: Deprecate FLAGS_quic_always_write_queued_retransmissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128171703
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 1f86a07958641a7b74abeb22b5c9eddc9c36bd55..bbe15688bbc8f8c7397eb4ab7f0b535a7b622ac0 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -322,12 +322,6 @@ void QuicSentPacketManager::HandleAckForSentPackets(
}
}
-bool QuicSentPacketManager::HasRetransmittableFrames(
- QuicPathId,
- QuicPacketNumber packet_number) const {
- return unacked_packets_.HasRetransmittableFrames(packet_number);
-}
-
void QuicSentPacketManager::RetransmitUnackedPackets(
TransmissionType retransmission_type) {
DCHECK(retransmission_type == ALL_UNACKED_RETRANSMISSION ||
@@ -535,11 +529,6 @@ void QuicSentPacketManager::MarkPacketHandled(QuicPacketNumber packet_number,
}
}
-bool QuicSentPacketManager::IsUnacked(QuicPathId,
- QuicPacketNumber packet_number) const {
- return unacked_packets_.IsUnacked(packet_number);
-}
-
bool QuicSentPacketManager::HasUnackedPackets() const {
return unacked_packets_.HasUnackedPackets();
}
@@ -562,12 +551,7 @@ bool QuicSentPacketManager::OnPacketSent(
<< "Cannot send empty packets.";
if (delegate_ == nullptr && original_packet_number != 0) {
- if (!pending_retransmissions_.erase(original_packet_number) &&
- !FLAGS_quic_always_write_queued_retransmissions) {
- QUIC_BUG << "Expected packet number to be in "
- << "pending_retransmissions_. packet_number: "
- << original_packet_number;
- }
+ pending_retransmissions_.erase(original_packet_number);
}
if (pending_timer_transmission_count_ > 0) {
@@ -927,7 +911,7 @@ void QuicSentPacketManager::CancelRetransmissionsForStream(
}
PendingRetransmissionMap::iterator it = pending_retransmissions_.begin();
while (it != pending_retransmissions_.end()) {
- if (HasRetransmittableFrames(path_id_, it->first)) {
+ if (unacked_packets_.HasRetransmittableFrames(it->first)) {
++it;
continue;
}
« no previous file with comments | « net/quic/quic_sent_packet_manager.h ('k') | net/quic/quic_sent_packet_manager_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698