Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: net/quic/quic_unacked_packet_map.cc

Issue 2179713004: Deprecate FLAGS_quic_always_write_queued_retransmissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128171703
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_unacked_packet_map.h" 5 #include "net/quic/quic_unacked_packet_map.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/stl_util.h" 8 #include "base/stl_util.h"
9 #include "net/quic/quic_bug_tracker.h" 9 #include "net/quic/quic_bug_tracker.h"
10 #include "net/quic/quic_connection_stats.h" 10 #include "net/quic/quic_connection_stats.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 ++least_unacked_; 84 ++least_unacked_;
85 } 85 }
86 } 86 }
87 87
88 void QuicUnackedPacketMap::TransferRetransmissionInfo( 88 void QuicUnackedPacketMap::TransferRetransmissionInfo(
89 QuicPacketNumber old_packet_number, 89 QuicPacketNumber old_packet_number,
90 QuicPacketNumber new_packet_number, 90 QuicPacketNumber new_packet_number,
91 TransmissionType transmission_type, 91 TransmissionType transmission_type,
92 TransmissionInfo* info) { 92 TransmissionInfo* info) {
93 if (old_packet_number < least_unacked_) { 93 if (old_packet_number < least_unacked_) {
94 if (!FLAGS_quic_always_write_queued_retransmissions) {
95 QUIC_BUG << "Old TransmissionInfo no longer exists for:"
96 << old_packet_number << " least_unacked:" << least_unacked_;
97 }
98 // This can happen when a retransmission packet is queued because of write 94 // This can happen when a retransmission packet is queued because of write
99 // blocked socket, and the original packet gets acked before the 95 // blocked socket, and the original packet gets acked before the
100 // retransmission gets sent. 96 // retransmission gets sent.
101 return; 97 return;
102 } 98 }
103 if (old_packet_number > largest_sent_packet_) { 99 if (old_packet_number > largest_sent_packet_) {
104 QUIC_BUG << "Old TransmissionInfo never existed for :" << old_packet_number 100 QUIC_BUG << "Old TransmissionInfo never existed for :" << old_packet_number
105 << " largest_sent:" << largest_sent_packet_; 101 << " largest_sent:" << largest_sent_packet_;
106 return; 102 return;
107 } 103 }
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 } 347 }
352 } 348 }
353 return false; 349 return false;
354 } 350 }
355 351
356 QuicPacketNumber QuicUnackedPacketMap::GetLeastUnacked() const { 352 QuicPacketNumber QuicUnackedPacketMap::GetLeastUnacked() const {
357 return least_unacked_; 353 return least_unacked_;
358 } 354 }
359 355
360 } // namespace net 356 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_sent_packet_manager_test.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698