Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: net/quic/quic_connection.cc

Issue 2179713004: Deprecate FLAGS_quic_always_write_queued_retransmissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128171703
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index f32b1ed31fd4ef5899cce70cb92128bcc4bc8fb2..e5bc5b16250a8000e10b0796f9f34a87cfef7401 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1748,25 +1748,6 @@ bool QuicConnection::ShouldDiscardPacket(const SerializedPacket& packet) {
return true;
}
- // TODO(fayang): Remove IsUnacked and HasRetransmittableFrames from
- // QuicSentPacketManagerInterface when deprecating
- // gfe2_reloadable_flag_quic_always_write_queued_retransmissions.
- if (FLAGS_quic_always_write_queued_retransmissions) {
- return false;
- }
-
- // If a retransmission has been acked before sending, don't send it.
- // This occurs if a packet gets serialized, queued, then discarded.
- if (packet.transmission_type != NOT_RETRANSMISSION &&
- (!sent_packet_manager_->IsUnacked(packet.original_path_id,
- packet.original_packet_number) ||
- !sent_packet_manager_->HasRetransmittableFrames(
- packet.original_path_id, packet.original_packet_number))) {
- DVLOG(1) << ENDPOINT << "Dropping unacked packet: " << packet_number
- << " A previous transmission was acked while write blocked.";
- return true;
- }
-
return false;
}
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698