build/config/features.gni - Issue 2179033002: Strip comments and whitespace from javascript resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/features.gni

Issue 2179033002: Strip comments and whitespace from javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One minor fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/features.gni

diff --git a/build/config/features.gni b/build/config/features.gni

index c1245af0d42408d3bbc6fd4d296df5dace6b63a3..5d852eedc1f8078444cc82239d8b9ffe09ca9c56 100644

--- a/build/config/features.gni

+++ b/build/config/features.gni

@@ -178,3 +178,7 @@ enable_configuration_policy = !is_ios

enable_mac_keystone = is_mac && is_chrome_branded && is_official_build

enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build

+# TODO(aberent): Enable for other platforms once the build machines have

+# Java on them (and hence can run the closure compiler).

+strip_resource_files = is_android

Dirk Pranke 2016/07/25 21:12:36 Does this really need to be in features.gni ? Can

brettw 2016/07/26 21:01:01 Yes, please, see the comment at the top of this fi

aberent 2016/07/27 09:46:35 Done.

« no previous file with comments | « no previous file | third_party/closure_compiler/compile2.py » ('j') | third_party/closure_compiler/js_minify.py » ('J')