third_party/closure_compiler/compile2.py - Issue 2179033002: Strip comments and whitespace from javascript resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2179033002: Strip comments and whitespace from javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One minor fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/closure_compiler/compile2.py

diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py

index df844d129109dc082700ee9e89fe45d6dc534117..036a52f3625c07b3b44d70e61d10eca90a8912ee 100755

--- a/third_party/closure_compiler/compile2.py

+++ b/third_party/closure_compiler/compile2.py

@@ -224,7 +224,7 @@ class Checker(object):

self._log_debug("Dependencies: %s" % deps)

self._log_debug("Target: %s" % self._target)

- js_args = deps + [self._target] if self._target else []

+ js_args = deps + ([self._target] if self._target else [])

if not custom_sources:

# TODO(dbeam): compiler.jar automatically detects "@externs" in a --js arg

@@ -270,7 +270,7 @@ class Checker(object):

errors = stderr.strip().split("\n\n")

maybe_summary = errors.pop()

- if re.search(".*error.*warning.*typed", maybe_summary):

+ if re.search(".*error.*warning", maybe_summary):

self._log_debug("Summary: %s" % maybe_summary)

else:

# Not a summary. Running the jar failed. Bail.

« build/config/features.gni ('K') | « build/config/features.gni ('k') | third_party/closure_compiler/js_minify.py » ('j') | third_party/closure_compiler/js_minify.py » ('J')