Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2179033002:
Strip comments and whitespace from javascript resources (Closed)
|
Created:
4 years, 5 months ago by aberent Modified:
4 years, 4 months ago CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org, brettw, Lei Zhang, jochen (gone - plz use gerrit), agrieve, Bernhard Bauer, Torne Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStrip comments and whitespace from javascript resources
On Android strip comments and whitespace from javascript resources.
Add an option to grit build that provides a command that strips
comments and whitespace, and modify grit so that this is applied
to all javascript resource and scripts within HTML resources.
Add a python script that wraps the closure compiler to implement
this command.
Pull it all together with GN.
BUG=619091
Committed: https://crrev.com/8dfa12f1b8845bc912728471d19d9915119456d7
Cr-Commit-Position: refs/heads/master@{#409498}
Patch Set 1 #Patch Set 2 : One minor fix #
Total comments: 24
Patch Set 3 : Respond to comments, handle errors, avoid double minification #Patch Set 4 : Fix naming of GN variables, and rebase. #
Total comments: 6
Patch Set 5 : Disable extra Chrome specific processing in compiler. #Patch Set 6 : Remove all compiler options that cause code tranformation #
Total comments: 19
Patch Set 7 : Change upstream CL, and fix nits #Patch Set 8 : Change upstream CL, and fix nits #Patch Set 9 : Revert changes to screen.js (no longer needed for this CL) #
Messages
Total messages: 51 (33 generated)
aberent@chromium.org changed reviewers: + dbeam@chromium.org, dpranke@chromium.org
dbeam@chromium.org: Please review changes in closure_compiler dpranke@chromium.org: Please review changes in grit and features.gni This is an alternative to https://codereview.chromium.org/2094193004/. To my surprise it seems that creating the pak files is not on the critical path for the build, so although building just the pak files (on my desktop) now takes 2 to 3 minutes instead of 6 seconds, it makes no consistent difference to the time for a clean build. As such I have enabled it for all Android builds. I am adding the other reviewers of the previous CL to the cc list for this CL
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... File third_party/closure_compiler/js_minify.py (right): https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:11: closure_args = [ can we just compose these rather than duplicate them from closure_args.{gypi.gni}? https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:32: with tempfile.NamedTemporaryFile(suffix='.js') as t1, tempfile.NamedTemporaryFile(suffix='.js', delete=False) as t2: 80 col wrap https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:32: with tempfile.NamedTemporaryFile(suffix='.js') as t1, tempfile.NamedTemporaryFile(suffix='.js', delete=False) as t2: nit: use double quotes (") instead of single quotes (') as that's what this file generally does https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:40: this should be 2 blank lines between top-level globals https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:42: orig_stdout = sys.stdout you probably want to wrap this in a try/finally, i.e. orig_stdout = sys.stdout try: sys.stdout = sys.stderr result = Minify(...) finally: sys.stdout = orig_stdout https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:43: sys.stdout = sys.stderr why is this stderr/stdout redirection required?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
This is mostly okay, just a few more minor questions. https://codereview.chromium.org/2179033002/diff/20001/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2179033002/diff/20001/build/config/features.g... build/config/features.gni:184: strip_resource_files = is_android Does this really need to be in features.gni ? Can we move this into grit_rule.gni instead, since (IIUC) this only affects grit targets? https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... File third_party/closure_compiler/js_minify.py (right): https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:32: with tempfile.NamedTemporaryFile(suffix='.js') as t1, tempfile.NamedTemporaryFile(suffix='.js', delete=False) as t2: On 2016/07/25 17:29:16, Dan Beam wrote: > nit: use double quotes (") instead of single quotes (') as that's what this file > generally does I would actually change everything else to be single quotes since that's the normal style. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... File tools/grit/grit/format/html_inline.py (right): https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:133: preprocess_only=False, names_only=False, strip_whitespace = False, nit: no spaces between strip_whitespace=False. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:370: allow_external_script=False, strip_whitespace = True, same nit. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:386: strip_whitespace = strip_whitespace, same nit. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:425: strip_whitespace = False, same nit.
brettw@chromium.org changed reviewers: + brettw@chromium.org
https://codereview.chromium.org/2179033002/diff/20001/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2179033002/diff/20001/build/config/features.g... build/config/features.gni:184: strip_resource_files = is_android On 2016/07/25 21:12:36, Dirk Pranke wrote: > Does this really need to be in features.gni ? Can we move this into > grit_rule.gni instead, since (IIUC) this only affects grit targets? Yes, please, see the comment at the top of this file. In the grit file it should be prefixed with an underscore so it doesn't export the variable to all files referencing grit (underscore means .gni-file-local variable to GN).
https://codereview.chromium.org/2179033002/diff/20001/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/2179033002/diff/20001/build/config/features.g... build/config/features.gni:184: strip_resource_files = is_android On 2016/07/25 21:12:36, Dirk Pranke wrote: > Does this really need to be in features.gni ? Can we move this into > grit_rule.gni instead, since (IIUC) this only affects grit targets? Done. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... File third_party/closure_compiler/js_minify.py (right): https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:11: closure_args = [ On 2016/07/25 17:29:16, Dan Beam wrote: > can we just compose these rather than duplicate them from > closure_args.{gypi.gni}? Now using closure_args.gni. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:32: with tempfile.NamedTemporaryFile(suffix='.js') as t1, tempfile.NamedTemporaryFile(suffix='.js', delete=False) as t2: On 2016/07/25 17:29:16, Dan Beam wrote: > 80 col wrap Done. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:32: with tempfile.NamedTemporaryFile(suffix='.js') as t1, tempfile.NamedTemporaryFile(suffix='.js', delete=False) as t2: On 2016/07/25 21:12:36, Dirk Pranke wrote: > On 2016/07/25 17:29:16, Dan Beam wrote: > > nit: use double quotes (") instead of single quotes (') as that's what this > file > > generally does > > I would actually change everything else to be single quotes since that's the > normal style. Done. All single quotes. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:40: On 2016/07/25 17:29:16, Dan Beam wrote: > this should be 2 blank lines between top-level globals Done. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:42: orig_stdout = sys.stdout On 2016/07/25 17:29:16, Dan Beam wrote: > you probably want to wrap this in a try/finally, i.e. > > orig_stdout = sys.stdout > try: > sys.stdout = sys.stderr > result = Minify(...) > finally: > sys.stdout = orig_stdout Done. https://codereview.chromium.org/2179033002/diff/20001/third_party/closure_com... third_party/closure_compiler/js_minify.py:43: sys.stdout = sys.stderr On 2016/07/25 17:29:16, Dan Beam wrote: > why is this stderr/stdout redirection required? In traditional Unix pipeline style (and as I define in grit) this minifier takes its input on standard input, and produces its output (the minified JS file) on standard output. For this to work I have to ensure that standard output receives nothing other than the minified output, so have to redirect the compiler's standard output elsewhere. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... File tools/grit/grit/format/html_inline.py (right): https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:133: preprocess_only=False, names_only=False, strip_whitespace = False, On 2016/07/25 21:12:36, Dirk Pranke wrote: > nit: no spaces between strip_whitespace=False. Done. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:370: allow_external_script=False, strip_whitespace = True, On 2016/07/25 21:12:36, Dirk Pranke wrote: > same nit. Done. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:386: strip_whitespace = strip_whitespace, On 2016/07/25 21:12:36, Dirk Pranke wrote: > same nit. Done. https://codereview.chromium.org/2179033002/diff/20001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:425: strip_whitespace = False, On 2016/07/25 21:12:36, Dirk Pranke wrote: > same nit. Done.
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was unchecked by aberent@chromium.org
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... File third_party/closure_compiler/js_minify.py (right): https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... third_party/closure_compiler/js_minify.py:17: from compile2 import Checker nit: \n\n between top-level https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... third_party/closure_compiler/js_minify.py:26: tempfile.NamedTemporaryFile(suffix='.js') as t2: how do these get deleted? should you be specifying delete=True? https://codereview.chromium.org/2179033002/diff/60001/ui/login/screen.js File ui/login/screen.js (right): https://codereview.chromium.org/2179033002/diff/60001/ui/login/screen.js#newc... ui/login/screen.js:387: cr.exportPath('login') missing a semi-colon cr.exportPath('login'); ^
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... File third_party/closure_compiler/js_minify.py (right): https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... third_party/closure_compiler/js_minify.py:17: from compile2 import Checker On 2016/07/28 16:27:05, Dan Beam wrote: > nit: \n\n between top-level Done. https://codereview.chromium.org/2179033002/diff/60001/third_party/closure_com... third_party/closure_compiler/js_minify.py:26: tempfile.NamedTemporaryFile(suffix='.js') as t2: On 2016/07/28 16:27:05, Dan Beam wrote: > how do these get deleted? should you be specifying delete=True? No, it is the default, as you might expect, for temporary files. https://codereview.chromium.org/2179033002/diff/60001/ui/login/screen.js File ui/login/screen.js (right): https://codereview.chromium.org/2179033002/diff/60001/ui/login/screen.js#newc... ui/login/screen.js:387: cr.exportPath('login') On 2016/07/28 16:27:05, Dan Beam wrote: > missing a semi-colon > > cr.exportPath('login'); > ^ Done.
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Dirk - PTAL, I think everything in the grit area should now be stable. Dan - I will sync up with you later on how we resolve the conflicts between this and https://codereview.chromium.org/2117653002/ Note that I had to remove some more options that were causing js code transformations; which were then causing distiller test failures.
thestig@chromium.org changed reviewers: + thestig@chromium.org
https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... File tools/grit/grit/format/html_inline.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:21: from grit.format import minifier Alphabetical order. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... File tools/grit/grit/format/minifier.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:1: # Copyright (c) 2016 The Chromium Authors. All rights reserved. no (c) https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:7: import re Not used https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:18: if file_type == '.js' and __js_minifier: Not that you really need it, but you can negate this and return early. Then omit the else after the return. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:23: (stdout,stderr) = p.communicate(source) space after comma https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:25: print stderr Is this useful as is? Maybe only do it if the return code is not 0? https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/node/in... File tools/grit/grit/node/include.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/node/in... tools/grit/grit/node/include.py:88: # TODO(benrg/joi): Move this and other implementations of GetDataPackPair So there's another GetDataPackPair() in structure.py. Would JS minification there help? https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... File tools/grit/grit/tool/build.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... tools/grit/grit/tool/build.py:24: from grit.format import minifier alphabetical order please https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... tools/grit/grit/tool/build.py:130: --js-minifier A command to run to minify Javascript. If not set then s/run to/run the/
The CQ bit was checked by aberent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Note:- This should be dependent on https://codereview.chromium.org/2117653002/#ps60001, but it appears that something has gone wrong the with the dependency tracking. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... File tools/grit/grit/format/html_inline.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:21: from grit.format import minifier On 2016/08/02 16:47:47, Lei Zhang wrote: > Alphabetical order. It is. The existing convention in build.py is that, for example: from grit.node import include follows from grit import util I have followed this convention. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... File tools/grit/grit/format/minifier.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:1: # Copyright (c) 2016 The Chromium Authors. All rights reserved. On 2016/08/02 16:47:48, Lei Zhang wrote: > no (c) Done. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:7: import re On 2016/08/02 16:47:47, Lei Zhang wrote: > Not used Done. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:18: if file_type == '.js' and __js_minifier: On 2016/08/02 16:47:48, Lei Zhang wrote: > Not that you really need it, but you can negate this and return early. Then omit > the else after the return. Done. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:23: (stdout,stderr) = p.communicate(source) On 2016/08/02 16:47:47, Lei Zhang wrote: > space after comma Done. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/minifier.py:25: print stderr On 2016/08/02 16:47:48, Lei Zhang wrote: > Is this useful as is? Maybe only do it if the return code is not 0? Probably useful. It prints warnings from the compiler that don't cause failure but probably should be looked at. If there are no warnings it will be empty. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/node/in... File tools/grit/grit/node/include.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/node/in... tools/grit/grit/node/include.py:88: # TODO(benrg/joi): Move this and other implementations of GetDataPackPair On 2016/08/02 16:47:48, Lei Zhang wrote: > So there's another GetDataPackPair() in structure.py. Would JS minification > there help? Done, indirectly, in chrome_html.py https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... File tools/grit/grit/tool/build.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... tools/grit/grit/tool/build.py:24: from grit.format import minifier On 2016/08/02 16:47:48, Lei Zhang wrote: > alphabetical order please Done. https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/tool/bu... tools/grit/grit/tool/build.py:130: --js-minifier A command to run to minify Javascript. If not set then On 2016/08/02 16:47:48, Lei Zhang wrote: > s/run to/run the/ Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
grit lgtm, but there are red bots... https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... File tools/grit/grit/format/html_inline.py (right): https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... tools/grit/grit/format/html_inline.py:21: from grit.format import minifier On 2016/08/02 20:27:41, aberent wrote: > On 2016/08/02 16:47:47, Lei Zhang wrote: > > Alphabetical order. > It is. The existing convention in build.py is that, for example: Whoops, missed the dot. X_X
On 2016/08/02 20:43:32, Lei Zhang wrote: > grit lgtm, but there are red bots... > Thanks. The red bots are caused by Reitveld failing to pick up the dependency on Dan's CLs. Ravi, who implemented patch dependencies doesn't have any suggestions as to why, but I can fix this once Dan's CLs land (hopefully in the next few hours). > https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... > File tools/grit/grit/format/html_inline.py (right): > > https://codereview.chromium.org/2179033002/diff/90001/tools/grit/grit/format/... > tools/grit/grit/format/html_inline.py:21: from grit.format import minifier > On 2016/08/02 20:27:41, aberent wrote: > > On 2016/08/02 16:47:47, Lei Zhang wrote: > > > Alphabetical order. > > It is. The existing convention in build.py is that, for example: > > Whoops, missed the dot. X_X
lgtm
The CQ bit was checked by aberent@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2179033002/#ps150001 (title: "Revert changes to screen.js (no longer needed for this CL)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by aberent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #9 (id:150001)
Message was sent while issue was closed.
Description was changed from ========== Strip comments and whitespace from javascript resources On Android strip comments and whitespace from javascript resources. Add an option to grit build that provides a command that strips comments and whitespace, and modify grit so that this is applied to all javascript resource and scripts within HTML resources. Add a python script that wraps the closure compiler to implement this command. Pull it all together with GN. BUG=619091 ========== to ========== Strip comments and whitespace from javascript resources On Android strip comments and whitespace from javascript resources. Add an option to grit build that provides a command that strips comments and whitespace, and modify grit so that this is applied to all javascript resource and scripts within HTML resources. Add a python script that wraps the closure compiler to implement this command. Pull it all together with GN. BUG=619091 Committed: https://crrev.com/8dfa12f1b8845bc912728471d19d9915119456d7 Cr-Commit-Position: refs/heads/master@{#409498} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/8dfa12f1b8845bc912728471d19d9915119456d7 Cr-Commit-Position: refs/heads/master@{#409498} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
