build/config/features.gni - Issue 2179033002: Strip comments and whitespace from javascript resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/features.gni

Issue 2179033002: Strip comments and whitespace from javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One minor fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This file contains Chrome-feature-related build flags (see ui.gni for	5 # This file contains Chrome-feature-related build flags (see ui.gni for

6 # UI-related ones). These should theoretically be moved to the build files of	6 # UI-related ones). These should theoretically be moved to the build files of

7 # the features themselves.	7 # the features themselves.

8 #	8 #

9 # However, today we have many "bad" dependencies on some of these flags from,	9 # However, today we have many "bad" dependencies on some of these flags from,

10 # e.g. base, so they need to be global to match the GYP configuration. Also,	10 # e.g. base, so they need to be global to match the GYP configuration. Also,

(...skipping 160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
171 use_brlapi = is_chromeos	171 use_brlapi = is_chromeos

172	172

173 # Enable WebVR support by default on Android	173 # Enable WebVR support by default on Android

174 # Still requires command line flag to access API	174 # Still requires command line flag to access API

175 enable_webvr = is_android	175 enable_webvr = is_android

176	176

177 enable_configuration_policy = !is_ios	177 enable_configuration_policy = !is_ios

178	178

179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build	179 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build

180 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build	180 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build

	181

	182 # TODO(aberent): Enable for other platforms once the build machines have

	183 # Java on them (and hence can run the closure compiler).

	184 strip_resource_files = is_android
	Dirk Pranke 2016/07/25 21:12:36 Does this really need to be in features.gni ? Can Does this really need to be in features.gni ? Can we move this into grit_rule.gni instead, since (IIUC) this only affects grit targets? brettw 2016/07/26 21:01:01 Yes, please, see the comment at the top of this fi Show quoted text On 2016/07/25 21:12:36, Dirk Pranke wrote: > Does this really need to be in features.gni ? Can we move this into > grit_rule.gni instead, since (IIUC) this only affects grit targets? Yes, please, see the comment at the top of this file. In the grit file it should be prefixed with an underscore so it doesn't export the variable to all files referencing grit (underscore means .gni-file-local variable to GN). aberent 2016/07/27 09:46:35 Done. Show quoted text On 2016/07/25 21:12:36, Dirk Pranke wrote: > Does this really need to be in features.gni ? Can we move this into > grit_rule.gni instead, since (IIUC) this only affects grit targets? Done.
OLD	NEW

« no previous file with comments | « no previous file | third_party/closure_compiler/compile2.py » ('j') | third_party/closure_compiler/js_minify.py » ('J')