Remove spellchecker feedback.

Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellcheck feedback sender.
  - Spelling markers.
  - Word trimmer.
  - Observing context menu cancellation.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.

BUG=630858

[please use gerrit instead, 2016-07-23 21:05:30]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 21:05:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 21:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 21:23:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2016-07-23 22:12:55]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 22:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-23 22:13:04]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-07-23 22:14:43]

Description was changed from

==========
Make OnReceiveDocumentMarkers no-op

BUG=630858
==========

to

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes in the wild and the impending deprecation of spellcheck
feedback sender, this patch makes OnReceiveDocumentMarkers method no-op
and removes the relevant unit tests.

BUG=630858
==========

[please use gerrit instead, 2016-07-23 22:15:04]

Description was changed from

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes in the wild and the impending deprecation of spellcheck
feedback sender, this patch makes OnReceiveDocumentMarkers method no-op
and removes the relevant unit tests.

BUG=630858
==========

to

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes and the impending deprecation of spellcheck feedback
sender, this patch makes OnReceiveDocumentMarkers method no-op and
removes the relevant unit tests.

BUG=630858
==========

[please use gerrit instead, 2016-07-23 22:56:47]

Description was changed from

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes and the impending deprecation of spellcheck feedback
sender, this patch makes OnReceiveDocumentMarkers method no-op and
removes the relevant unit tests.

BUG=630858
==========

to

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes and the impending deprecation of spellcheck feedback
sender, this patch makes OnReceiveDocumentMarkers method no-op and
removes the relevant unit tests. This effectively disables the
feedback sender.

BUG=630858
==========

[commit-bot: I haz the power, 2016-07-23 22:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 22:57:06]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-07-23 22:57:51]

rouslan@chromium.org changed reviewers:
+ groby@chromium.org

[please use gerrit instead, 2016-07-23 22:57:52]

groby, ptal.

[groby-ooo-7-16, 2016-07-26 21:53:11]

On 2016/07/23 22:57:52, rouslan wrote:
> groby, ptal.

Not happy that we're plastering over it, but fine, let's no-op. Can you follow
up w/ removal soonish?

LGTM

[please use gerrit instead, 2016-07-26 21:54:48]

On 2016/07/26 21:53:11, groby wrote:
> Can you follow up w/ removal soonish?

Is next week soon enough?

[please use gerrit instead, 2016-07-30 00:11:01]

Too late to merge this to M-53, IMHO. So I will remove all feedback at once
instead.

[please use gerrit instead, 2016-07-30 03:04:57]

Description was changed from

==========
Make OnReceiveDocumentMarkers no-op

Due to crashes and the impending deprecation of spellcheck feedback
sender, this patch makes OnReceiveDocumentMarkers method no-op and
removes the relevant unit tests. This effectively disables the
feedback sender.

BUG=630858
==========

to

==========
Remove spellchecker feedback.

Removed in this patch:
 - Spellchecker feedback.
 - Invisible document markers.
 - Document marker hashes (identifiers).
 - Querying document markers.
 - Observing context menu cancellation (was used only for feedback).

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:05:28]

Description was changed from

==========
Remove spellchecker feedback.

Removed in this patch:
 - Spellchecker feedback.
 - Invisible document markers.
 - Document marker hashes (identifiers).
 - Querying document markers.
 - Observing context menu cancellation (was used only for feedback).

BUG=630858
==========

to

==========
Remove spellchecker feedback.

Removed in this patch:
 - Spellchecker feedback.
 - Invisible document markers.
 - Document marker hashes (identifiers).
 - Querying document markers.
 - Observing context menu cancellation (was used only for feedback).

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:09:34]

Description was changed from

==========
Remove spellchecker feedback.

Removed in this patch:
 - Spellchecker feedback.
 - Invisible document markers.
 - Document marker hashes (identifiers).
 - Querying document markers.
 - Observing context menu cancellation (was used only for feedback).

BUG=630858
==========

to

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structure throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Word trimmer.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.
  - Observing context menu cancellation.

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:35:50]

Description was changed from

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structure throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Word trimmer.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.
  - Observing context menu cancellation.

BUG=630858
==========

to

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Misspelling structure.
  - Word trimmer.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.
  - Observing context menu cancellation.

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:36:21]

Description was changed from

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Misspelling structure.
  - Word trimmer.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.
  - Observing context menu cancellation.

BUG=630858
==========

to

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Word trimmer.
  - Observing context menu cancellation.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:36:55]

Description was changed from

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellchecker feedback.
  - Spellcheck markers.
  - Word trimmer.
  - Observing context menu cancellation.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.

BUG=630858
==========

to

==========
Remove spellchecker feedback.

This patch removes spellchecker feedback and all of its supporting data
structures and algorithms throughout Chrome and Blink.

 * Removed from browser:

  - Spellcheck feedback sender.
  - Spelling markers.
  - Word trimmer.
  - Observing context menu cancellation.

 * Removed from renderer:

  - Invisible document markers.
  - Document marker hashes.
  - Querying document markers.

BUG=630858
==========

[please use gerrit instead, 2016-07-30 03:37:03]

Patchset #2 (id:40001) has been deleted

[please use gerrit instead, 2016-07-30 03:37:08]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 03:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-30 03:37:49]

groby, ptal patch 2.

[commit-bot: I haz the power, 2016-07-30 03:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 03:56:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[please use gerrit instead, 2016-07-30 18:58:55]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 18:59:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 20:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 20:15:35]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-08-02 16:26:16]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 16:39:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 16:39:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[groby-ooo-7-16, 2016-08-03 17:24:39]

On 2016/07/30 03:37:49, rouslan wrote:
> groby, ptal patch 2.

Before I scan the entire patch again - what changed after my LG?

[please use gerrit instead, 2016-08-03 17:50:56]

On 2016/08/03 17:24:39, groby wrote:
> Before I scan the entire patch again - what changed after my LG?

Entire feedback was removed. (Your LG was for making one feedback function
no-op.)

[please use gerrit instead, 2016-08-03 18:35:55]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 19:07:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:07:39]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[groby-ooo-7-16, 2016-08-04 01:32:51]

On 2016/08/03 17:50:56, rouslan wrote:
> On 2016/08/03 17:24:39, groby wrote:
> > Before I scan the entire patch again - what changed after my LG?
> 
> Entire feedback was removed. (Your LG was for making one feedback function
> no-op.)

Urg. This is large. Expect delays :)

[groby-ooo-7-16, 2016-08-04 01:38:46]

On 2016/08/04 01:32:51, groby wrote:
> On 2016/08/03 17:50:56, rouslan wrote:
> > On 2016/08/03 17:24:39, groby wrote:
> > > Before I scan the entire patch again - what changed after my LG?
> > 
> > Entire feedback was removed. (Your LG was for making one feedback function
> > no-op.)
> 
> Urg. This is large. Expect delays :)

Leaving a marker for my future self - chrome/* is LG