Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc

Issue 2177023002: Remove spellchecker feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc
index ad933ea254238d13d46a32fc32951bce40471747..b98fdec37f2f5b6a1d980c3486652d197fe4fbe4 100644
--- a/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc
@@ -13,7 +13,6 @@
#include "chrome/browser/spellchecker/spellcheck_message_filter.h"
#include "chrome/browser/spellchecker/spellcheck_service.h"
#include "chrome/test/base/testing_profile.h"
-#include "components/spellcheck/common/spellcheck_marker.h"
#include "components/spellcheck/common/spellcheck_messages.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "ipc/ipc_message.h"
@@ -37,12 +36,11 @@ class TestingSpellCheckMessageFilter : public SpellCheckMessageFilter {
#if !defined(USE_BROWSER_SPELLCHECKER)
void OnTextCheckComplete(int route_id,
int identifier,
- const std::vector<SpellCheckMarker>& markers,
bool success,
const base::string16& text,
const std::vector<SpellCheckResult>& results) {
SpellCheckMessageFilter::OnTextCheckComplete(
- route_id, identifier, markers, success, text, results);
+ route_id, identifier, success, text, results);
}
#endif
@@ -62,7 +60,6 @@ TEST(SpellCheckMessageFilterTest, TestOverrideThread) {
static const uint32_t kSpellcheckMessages[] = {
SpellCheckHostMsg_RequestDictionary::ID,
SpellCheckHostMsg_NotifyChecked::ID,
- SpellCheckHostMsg_RespondDocumentMarkers::ID,
#if !defined(USE_BROWSER_SPELLCHECKER)
SpellCheckHostMsg_CallSpellingService::ID,
#endif
@@ -85,7 +82,6 @@ TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTestCustomDictionary) {
static const std::string kCustomWord = "Helllo";
static const int kRouteId = 0;
static const int kCallbackId = 0;
- static const std::vector<SpellCheckMarker> kMarkers;
static const base::string16 kText = base::ASCIIToUTF16("Helllo warld.");
static const bool kSuccess = true;
static const SpellCheckResult::Decoration kDecoration =
@@ -104,7 +100,7 @@ TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTestCustomDictionary) {
new TestingSpellCheckMessageFilter);
filter->GetSpellcheckService()->GetCustomDictionary()->AddWord(kCustomWord);
filter->OnTextCheckComplete(
- kRouteId, kCallbackId, kMarkers, kSuccess, kText, results);
+ kRouteId, kCallbackId, kSuccess, kText, results);
EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size());
SpellCheckMsg_RespondSpellingService::Param params;
@@ -134,8 +130,8 @@ TEST(SpellCheckMessageFilterTest, OnTextCheckCompleteTest) {
scoped_refptr<TestingSpellCheckMessageFilter> filter(
new TestingSpellCheckMessageFilter);
- filter->OnTextCheckComplete(1, 1, std::vector<SpellCheckMarker>(),
- true, base::ASCIIToUTF16("Helllo walrd"), results);
+ filter->OnTextCheckComplete(1, 1, true, base::ASCIIToUTF16("Helllo walrd"),
+ results);
EXPECT_EQ(static_cast<size_t>(1), filter->sent_messages.size());
SpellCheckMsg_RespondSpellingService::Param params;

Powered by Google App Engine
This is Rietveld 408576698