Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

Issue 2177023002: Remove spellchecker feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/spelling_menu_observer.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
index d45eb2319b79a83cf77ca43fb345f15d98005843..f997d3be5357a87093cea0a1d0bc59a851769314 100644
--- a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
@@ -14,7 +14,6 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "chrome/browser/renderer_context_menu/spelling_bubble_model.h"
-#include "chrome/browser/spellchecker/feedback_sender.h"
#include "chrome/browser/spellchecker/spellcheck_factory.h"
#include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
#include "chrome/browser/spellchecker/spellcheck_platform.h"
@@ -44,7 +43,6 @@ SpellingMenuObserver::SpellingMenuObserver(RenderViewContextMenuProxy* proxy)
: proxy_(proxy),
loading_frame_(0),
succeeded_(false),
- misspelling_hash_(0),
client_(new SpellingServiceClient) {
if (proxy_ && proxy_->GetBrowserContext()) {
Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
@@ -73,7 +71,6 @@ void SpellingMenuObserver::InitMenu(const content::ContextMenuParams& params) {
suggestions_ = params.dictionary_suggestions;
misspelled_word_ = params.misspelled_word;
- misspelling_hash_ = params.misspelling_hash;
bool use_suggestions = SpellingServiceClient::IsAvailable(
browser_context, SpellingServiceClient::SUGGEST);
@@ -240,8 +237,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
if (spellcheck->GetMetrics())
spellcheck->GetMetrics()->RecordReplacedWordStats(1);
- spellcheck->GetFeedbackSender()->SelectedSuggestion(
- misspelling_hash_, suggestion_index);
}
}
return;
@@ -266,7 +261,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
spellcheck->GetCustomDictionary()->AddWord(base::UTF16ToUTF8(
misspelled_word_));
- spellcheck->GetFeedbackSender()->AddedToDictionary(misspelling_hash_);
}
}
#if defined(USE_BROWSER_SPELLCHECKER)
@@ -301,17 +295,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
}
}
-void SpellingMenuObserver::OnMenuCancel() {
- content::BrowserContext* browser_context = proxy_->GetBrowserContext();
- if (!browser_context)
- return;
- SpellcheckService* spellcheck =
- SpellcheckServiceFactory::GetForContext(browser_context);
- if (!spellcheck)
- return;
- spellcheck->GetFeedbackSender()->IgnoredSuggestions(misspelling_hash_);
-}
-
void SpellingMenuObserver::OnTextCheckComplete(
SpellingServiceClient::ServiceType type,
bool success,
« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.h ('k') | chrome/browser/spellchecker/feedback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698