Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3138)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc

Issue 2177023002: Remove spellchecker feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc b/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc
index e5178fc3f274a826541eb0563d7b6cb3558bd5fc..9a80a071b46d7741b7f6529506638c2dfa1d1489 100644
--- a/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform_mac.cc
@@ -9,7 +9,6 @@
#include "base/barrier_closure.h"
#include "base/bind.h"
-#include "chrome/browser/spellchecker/feedback_sender.h"
#include "chrome/browser/spellchecker/spellcheck_factory.h"
#include "chrome/browser/spellchecker/spellcheck_platform.h"
#include "chrome/browser/spellchecker/spellcheck_service.h"
@@ -40,8 +39,7 @@ class SpellingRequest {
void RequestCheck(const base::string16& text,
int route_id,
int identifier,
- int document_tag,
- const std::vector<SpellCheckMarker>& markers);
+ int document_tag);
private:
// Request server-side checking for |text_|.
void RequestRemoteCheck();
@@ -75,7 +73,6 @@ class SpellingRequest {
int route_id_;
int identifier_;
int document_tag_;
- std::vector<SpellCheckMarker> markers_;
};
SpellingRequest::SpellingRequest(SpellingServiceClient* client,
@@ -95,8 +92,7 @@ void SpellingRequest::RequestCheck(
const base::string16& text,
int route_id,
int identifier,
- int document_tag,
- const std::vector<SpellCheckMarker>& markers) {
+ int document_tag) {
DCHECK(!text.empty());
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -104,7 +100,6 @@ void SpellingRequest::RequestCheck(
route_id_ = route_id;
identifier_ = identifier;
document_tag_ = document_tag;
- markers_ = markers;
// Send the remote query out. The barrier owns |this|, ensuring it is deleted
// after completion.
@@ -169,17 +164,6 @@ void SpellingRequest::OnRemoteCheckCompleted(
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
remote_success_ = success;
remote_results_ = results;
-
- SpellcheckService* spellcheck_service =
- SpellcheckServiceFactory::GetForRenderProcessId(render_process_id_);
- if (spellcheck_service) {
- spellcheck_service->GetFeedbackSender()->OnSpellcheckResults(
- render_process_id_,
- text,
- markers_,
- &remote_results_);
- }
-
completion_barrier_.Run();
}
@@ -277,8 +261,7 @@ void SpellCheckMessageFilterPlatform::OnUpdateSpellingPanelWithMisspelledWord(
void SpellCheckMessageFilterPlatform::OnRequestTextCheck(
int route_id,
int identifier,
- const base::string16& text,
- std::vector<SpellCheckMarker> markers) {
+ const base::string16& text) {
DCHECK(!text.empty());
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -288,18 +271,10 @@ void SpellCheckMessageFilterPlatform::OnRequestTextCheck(
// happen on UI thread.
SpellcheckServiceFactory::GetForRenderProcessId(render_process_id_);
- // Erase invalid markers (with offsets out of boundaries of text length).
- markers.erase(
- std::remove_if(
- markers.begin(),
- markers.end(),
- std::not1(SpellCheckMarker::IsValidPredicate(text.length()))),
- markers.end());
// SpellingRequest self-destructs.
SpellingRequest* request =
new SpellingRequest(client_.get(), this, render_process_id_);
- request->RequestCheck(
- text, route_id, identifier, ToDocumentTag(route_id), markers);
+ request->RequestCheck(text, route_id, identifier, ToDocumentTag(route_id));
}
int SpellCheckMessageFilterPlatform::ToDocumentTag(int route_id) {

Powered by Google App Engine
This is Rietveld 408576698