Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2175743004: Cherry-pick infra assets changes to chrome/m53 to prevent bots breaking (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
dogben, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m53
Target Ref:
refs/heads/chrome/m53
Project:
skia
Visibility:
Public.

Description

Cherry-pick infra assets changes to chrome/m53 to prevent bots breaking ----- Change SKPs to new asset management format BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169653003 DOCS_PREVIEW= https://skia.org/?cl=2169653003 Review-Url: https://codereview.chromium.org/2169653003 ----- Add "skp" asset Don't get rid of SKP_VERSION and associated stuff just yet. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002 DOCS_PREVIEW= https://skia.org/?cl=2167763002 Review-Url: https://codereview.chromium.org/2167763002 ----- Add vulkan sdk to CIPD BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164953002 Review-Url: https://codereview.chromium.org/2164953002 ----- BUG=630725 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/eee1b9f17e74cee4f768cba2fec368bd410064d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -219 lines) Patch
D SKP_VERSION View 1 chunk +0 lines, -1 line 0 comments Download
M bin/fetch-skps View 1 chunk +2 lines, -20 lines 0 comments Download
A infra/bots/assets/skp/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + infra/bots/assets/skp/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/skp/create.py View 1 chunk +88 lines, -0 lines 0 comments Download
A + infra/bots/assets/skp/create_and_upload.py View 2 chunks +5 lines, -8 lines 0 comments Download
A + infra/bots/assets/skp/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skp/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/win_vulkan_sdk/README.md View 1 chunk +7 lines, -0 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/VERSION View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D infra/bots/common.py View 1 chunk +0 lines, -53 lines 0 comments Download
D infra/bots/download_skps.py View 1 chunk +0 lines, -28 lines 0 comments Download
M infra/bots/perf_skia.isolate View 1 chunk +5 lines, -1 line 0 comments Download
D infra/bots/skps.isolate View 1 chunk +0 lines, -8 lines 0 comments Download
M infra/bots/test_skia.isolate View 1 chunk +5 lines, -1 line 0 comments Download
M site/dev/testing/skps.md View 1 chunk +4 lines, -9 lines 0 comments Download
D tools/skp/recreate_skps.py View 1 chunk +0 lines, -96 lines 0 comments Download
M tools/skp/webpages_playback.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
borenet
4 years, 5 months ago (2016-07-22 19:59:21 UTC) #4
dogben
lgtm
4 years, 5 months ago (2016-07-22 20:04:37 UTC) #5
dogben
On 2016/07/22 at 20:04:37, Ben Wagner wrote: > lgtm Do you need to go through ...
4 years, 5 months ago (2016-07-22 20:05:08 UTC) #6
borenet
On 2016/07/22 20:05:08, Ben Wagner wrote: > On 2016/07/22 at 20:04:37, Ben Wagner wrote: > ...
4 years, 5 months ago (2016-07-25 11:32:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175743004/1
4 years, 5 months ago (2016-07-25 11:33:58 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:34:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eee1b9f17e74cee4f768cba2fec368bd410064d9

Powered by Google App Engine
This is Rietveld 408576698