Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2169653003: Change SKPs to new asset management format (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add VERSION file #

Patch Set 3 : Fix isolate directory structure #

Patch Set 4 : Add --upload_to_partner_bucket flag to create.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -42 lines) Patch
D SKP_VERSION View 1 chunk +0 lines, -1 line 0 comments Download
M bin/fetch-skps View 1 chunk +2 lines, -20 lines 0 comments Download
A infra/bots/assets/skp/VERSION View 1 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/assets/skp/create.py View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M infra/bots/perf_skia.isolate View 1 2 1 chunk +5 lines, -1 line 0 comments Download
D infra/bots/skps.isolate View 1 chunk +0 lines, -8 lines 0 comments Download
M infra/bots/test_skia.isolate View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M site/dev/testing/skps.md View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
borenet
Depends on https://codereview.chromium.org/2167883004/
4 years, 5 months ago (2016-07-21 18:40:04 UTC) #3
rmistry
lgtm
4 years, 5 months ago (2016-07-22 14:27:44 UTC) #4
borenet
Added --upload_to_partner_bucket flag to create.py
4 years, 5 months ago (2016-07-22 14:58:18 UTC) #5
rmistry
lgtm
4 years, 5 months ago (2016-07-22 14:58:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169653003/60001
4 years, 5 months ago (2016-07-22 15:07:42 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 15:31:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/1543487fc642b443283ace3fa37e6597cd89061f

Powered by Google App Engine
This is Rietveld 408576698