Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2164953002: Add vulkan sdk to CIPD (Closed)

Created:
4 years, 5 months ago by kjlubick
Modified:
4 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add asset readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --4 lines) Patch
A infra/bots/assets/win_vulkan_sdk/README.md View 1 1 chunk +7 lines, -0 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/VERSION View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/win_vulkan_sdk/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjlubick
4 years, 5 months ago (2016-07-20 13:46:56 UTC) #3
borenet
I recommend landing this in two parts: 1. Land the recipe-side change to swarm_trigger which ...
4 years, 5 months ago (2016-07-20 13:49:58 UTC) #4
kjlubick
On 2016/07/20 at 13:49:58, borenet wrote: > I recommend landing this in two parts: > ...
4 years, 5 months ago (2016-07-20 13:51:55 UTC) #5
borenet
(LGTM when you have the recipe-side change done) Minor note: it may be worth adding ...
4 years, 5 months ago (2016-07-20 13:55:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164953002/20001
4 years, 5 months ago (2016-07-20 16:57:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:18:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f2944815e5e490c843c5a364fcaae2471526562f

Powered by Google App Engine
This is Rietveld 408576698