Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 2167763002: Add "skp" asset (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add "skp" asset Don't get rid of SKP_VERSION and associated stuff just yet. BUG=skia:5427 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167763002 DOCS_PREVIEW= https://skia.org/?cl=2167763002 Committed: https://skia.googlesource.com/skia/+/85f0e63ca476568143a36242b438390f7e6d5c82

Patch Set 1 #

Patch Set 2 : Fix create_and_upload #

Patch Set 3 : re-upload #

Patch Set 4 : Backpedal: Don't get rid of old SKPs yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -183 lines) Patch
A + infra/bots/assets/skp/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A infra/bots/assets/skp/create.py View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A + infra/bots/assets/skp/create_and_upload.py View 1 2 chunks +5 lines, -8 lines 0 comments Download
A + infra/bots/assets/skp/download.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + infra/bots/assets/skp/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D infra/bots/common.py View 1 chunk +0 lines, -53 lines 0 comments Download
D infra/bots/download_skps.py View 1 chunk +0 lines, -28 lines 0 comments Download
D tools/skp/recreate_skps.py View 1 chunk +0 lines, -96 lines 0 comments Download
M tools/skp/webpages_playback.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
borenet
4 years, 5 months ago (2016-07-21 17:07:05 UTC) #4
rmistry
lgtm
4 years, 5 months ago (2016-07-21 17:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167763002/60001
4 years, 5 months ago (2016-07-21 17:16:26 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:27:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/85f0e63ca476568143a36242b438390f7e6d5c82

Powered by Google App Engine
This is Rietveld 408576698