Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 217563003: Turn styleWillChange |newStyle| into a reference (Closed)

Created:
6 years, 9 months ago by Julien - ping for review
Modified:
6 years, 8 months ago
Reviewers:
eseidel, esprehn, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, leviw_travelin_and_unemployed
Visibility:
Public.

Description

Turn styleWillChange |newStyle| into a reference The parameter was never NULL but the code wasn't clear about it. This lead to a couple of unneeded NULL-checks that obfuscated what could happen. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170482

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -237 lines) Patch
M Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +8 lines, -6 lines 2 comments Download
M Source/core/rendering/RenderButton.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderButton.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 5 chunks +31 lines, -31 lines 0 comments Download
M Source/core/rendering/RenderScrollbarPart.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarPart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 7 chunks +154 lines, -154 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
This removes some crazy NULL-check in the code and makes it more obvious what's going ...
6 years, 8 months ago (2014-03-31 20:02:23 UTC) #1
esprehn
lgtm, word. https://codereview.chromium.org/217563003/diff/1/Source/core/rendering/RenderBox.cpp File Source/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/217563003/diff/1/Source/core/rendering/RenderBox.cpp#newcode168 Source/core/rendering/RenderBox.cpp:168: // so what's the point in invalidating ...
6 years, 8 months ago (2014-03-31 20:07:51 UTC) #2
Julien - ping for review
https://codereview.chromium.org/217563003/diff/1/Source/core/rendering/RenderBox.cpp File Source/core/rendering/RenderBox.cpp (right): https://codereview.chromium.org/217563003/diff/1/Source/core/rendering/RenderBox.cpp#newcode168 Source/core/rendering/RenderBox.cpp:168: // so what's the point in invalidating the whole ...
6 years, 8 months ago (2014-03-31 20:20:26 UTC) #3
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 8 months ago (2014-03-31 20:20:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/217563003/1
6 years, 8 months ago (2014-03-31 20:20:35 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 20:30:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 170482

Powered by Google App Engine
This is Rietveld 408576698