Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/core/rendering/RenderScrollbarPart.h

Issue 217563003: Turn styleWillChange |newStyle| into a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 // Scrollbar parts needs to be rendered at device pixel boundaries. 50 // Scrollbar parts needs to be rendered at device pixel boundaries.
51 virtual LayoutUnit marginTop() const OVERRIDE { ASSERT(isIntegerValue(m_marg inBox.top())); return m_marginBox.top(); } 51 virtual LayoutUnit marginTop() const OVERRIDE { ASSERT(isIntegerValue(m_marg inBox.top())); return m_marginBox.top(); }
52 virtual LayoutUnit marginBottom() const OVERRIDE { ASSERT(isIntegerValue(m_m arginBox.bottom())); return m_marginBox.bottom(); } 52 virtual LayoutUnit marginBottom() const OVERRIDE { ASSERT(isIntegerValue(m_m arginBox.bottom())); return m_marginBox.bottom(); }
53 virtual LayoutUnit marginLeft() const OVERRIDE { ASSERT(isIntegerValue(m_mar ginBox.left())); return m_marginBox.left(); } 53 virtual LayoutUnit marginLeft() const OVERRIDE { ASSERT(isIntegerValue(m_mar ginBox.left())); return m_marginBox.left(); }
54 virtual LayoutUnit marginRight() const OVERRIDE { ASSERT(isIntegerValue(m_ma rginBox.right())); return m_marginBox.right(); } 54 virtual LayoutUnit marginRight() const OVERRIDE { ASSERT(isIntegerValue(m_ma rginBox.right())); return m_marginBox.right(); }
55 55
56 virtual bool isRenderScrollbarPart() const OVERRIDE { return true; } 56 virtual bool isRenderScrollbarPart() const OVERRIDE { return true; }
57 RenderObject* rendererOwningScrollbar() const; 57 RenderObject* rendererOwningScrollbar() const;
58 58
59 protected: 59 protected:
60 virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle) O VERRIDE; 60 virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle) O VERRIDE;
61 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OV ERRIDE; 61 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OV ERRIDE;
62 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) OVERRIDE; 62 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) OVERRIDE;
63 63
64 private: 64 private:
65 RenderScrollbarPart(RenderScrollbar*, ScrollbarPart); 65 RenderScrollbarPart(RenderScrollbar*, ScrollbarPart);
66 66
67 virtual void computePreferredLogicalWidths() OVERRIDE; 67 virtual void computePreferredLogicalWidths() OVERRIDE;
68 68
69 // Have all padding getters return 0. The important point here is to avoid r esolving percents 69 // Have all padding getters return 0. The important point here is to avoid r esolving percents
70 // against the containing block, since scroll bar corners don't always have one (so it would 70 // against the containing block, since scroll bar corners don't always have one (so it would
(...skipping 16 matching lines...) Expand all
87 87
88 RenderScrollbar* m_scrollbar; 88 RenderScrollbar* m_scrollbar;
89 ScrollbarPart m_part; 89 ScrollbarPart m_part;
90 }; 90 };
91 91
92 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderScrollbarPart, isRenderScrollbarPart()); 92 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderScrollbarPart, isRenderScrollbarPart());
93 93
94 } // namespace WebCore 94 } // namespace WebCore
95 95
96 #endif // RenderScrollbarPart_h 96 #endif // RenderScrollbarPart_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698