Source/core/rendering/RenderDeprecatedFlexibleBox.cpp - Issue 217563003: Turn styleWillChange |newStyle| into a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

Issue 217563003: Turn styleWillChange |newStyle| into a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

diff --git a/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp b/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

index 71f598d3ff227fcec1ff0152e64c9dcfd35b203f..fd954f4c4c433a77d6bb0098d5d47b63cdc76d65 100644

--- a/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

+++ b/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp

@@ -182,10 +182,10 @@ static LayoutUnit contentHeightForChild(RenderBox* child)

return child->logicalHeight() - child->borderAndPaddingLogicalHeight();

}

-void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff, const RenderStyle* newStyle)

+void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff, const RenderStyle& newStyle)

{

RenderStyle* oldStyle = style();

- if (oldStyle && !oldStyle->lineClamp().isNone() && newStyle->lineClamp().isNone())

+ if (oldStyle && !oldStyle->lineClamp().isNone() && newStyle.lineClamp().isNone())

clearLineClamp();

RenderBlock::styleWillChange(diff, newStyle);