Source/core/rendering/RenderButton.h - Issue 217563003: Turn styleWillChange |newStyle| into a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderButton.h

Issue 217563003: Turn styleWillChange |newStyle| into a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderButton.h

diff --git a/Source/core/rendering/RenderButton.h b/Source/core/rendering/RenderButton.h

index c90dd59586077b45c1cbc1dc2b6868d2f5723b6c..dd922e71df8fcf209f2b26632ce4e82fd1e38194 100644

--- a/Source/core/rendering/RenderButton.h

+++ b/Source/core/rendering/RenderButton.h

@@ -59,7 +59,7 @@ public:

virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode) const OVERRIDE;

private:

- virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle) OVERRIDE;

+ virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle) OVERRIDE;

virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;

virtual bool hasLineIfEmpty() const OVERRIDE { return isHTMLInputElement(node()); }