Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/744e856254e98e5cacf311d5ee989e2fa5cb3252
Cr-Commit-Position: refs/heads/master@{#407513}

[erikchen, 2016-07-23 00:05:22]

Description was changed from

==========
Add command decoder function filter effects.

BUG=
==========

to

==========
Add command decoder function filter effects.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-07-23 00:05:23]

Description was changed from

==========
Add command decoder function filter effects.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add command decoder function filter effects.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-23 00:14:09]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 00:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-07-23 00:20:03]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 00:20:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-07-23 00:21:57]

Description was changed from

==========
Add command decoder function filter effects.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-23 00:26:47]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-07-23 00:26:48]

piman: Please review.

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:41: GLint type;
I could add 10 new parameters, and add conversions between them and
ui::CARendererLayerParams::FilterEffectType. This seems like a lot of plumbing
for no benefit.

[erikchen, 2016-07-23 00:26:57]

Description was changed from

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-23 00:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 00:37:08]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[piman, 2016-07-23 00:39:58]

2 smallish things, then lgtm

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:41: GLint type;
On 2016/07/23 00:26:48, erikchen wrote:
> I could add 10 new parameters, and add conversions between them and
> ui::CARendererLayerParams::FilterEffectType. This seems like a lot of plumbing
> for no benefit.

SG. Can you list what are the valid values here?

https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10927: filter_type >
ui::CARendererLayerParams::FilterEffectType::MAX) {
Could you do the check on filter_effect.type, before the cast? Having casting a
value outside the bounds for FilterEffectType would be undefined behavior, so
the compiler is allowed to assume both these are false no matter what!

[erikchen, 2016-07-23 01:19:23]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 01:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-07-23 01:38:28]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 01:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 02:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:34:45]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-07-23 14:18:15]

piman: PTAL at gpu/command_buffer/build_gles2_cmd_buffer.py, as I made some
non-trivial changes since PS2.

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):

https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:41: GLint type;
On 2016/07/23 00:39:58, piman - slow reviews until 8-8 wrote:
> On 2016/07/23 00:26:48, erikchen wrote:
> > I could add 10 new parameters, and add conversions between them and
> > ui::CARendererLayerParams::FilterEffectType. This seems like a lot of
plumbing
> > for no benefit.
> 
> SG. Can you list what are the valid values here?

Done.

https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10927: filter_type >
ui::CARendererLayerParams::FilterEffectType::MAX) {
On 2016/07/23 00:39:58, piman - slow reviews until 8-8 wrote:
> Could you do the check on filter_effect.type, before the cast? Having casting
a
> value outside the bounds for FilterEffectType would be undefined behavior, so
> the compiler is allowed to assume both these are false no matter what!

ah good point. done.

[erikchen, 2016-07-25 17:11:23]

On 2016/07/23 14:18:15, erikchen wrote:
> piman: PTAL at gpu/command_buffer/build_gles2_cmd_buffer.py, as I made some
> non-trivial changes since PS2.
> 
>
https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
> File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):
> 
>
https://codereview.chromium.org/2175043002/diff/20001/gpu/GLES2/extensions/CH...
> gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:41: GLint type;
> On 2016/07/23 00:39:58, piman - slow reviews until 8-8 wrote:
> > On 2016/07/23 00:26:48, erikchen wrote:
> > > I could add 10 new parameters, and add conversions between them and
> > > ui::CARendererLayerParams::FilterEffectType. This seems like a lot of
> plumbing
> > > for no benefit.
> > 
> > SG. Can you list what are the valid values here?
> 
> Done.
> 
>
https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2175043002/diff/20001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:10927: filter_type >
> ui::CARendererLayerParams::FilterEffectType::MAX) {
> On 2016/07/23 00:39:58, piman - slow reviews until 8-8 wrote:
> > Could you do the check on filter_effect.type, before the cast? Having
casting
> a
> > value outside the bounds for FilterEffectType would be undefined behavior,
so
> > the compiler is allowed to assume both these are false no matter what!
> 
> ah good point. done.

Looks like piman@ is at a conference for the entire week. I'm going to land this
as is, since it passes all tests. piman: Feel free to review
build_gles2_cmd_buffer.py after this CL has landed, and I will make changes that
you deem necessary.

[erikchen, 2016-07-25 17:11:30]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-25 17:11:30]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2175043002/#ps80001
(title: "Fix autogenerated tests.")

[commit-bot: I haz the power, 2016-07-25 17:11:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:08:52]

Description was changed from

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-25 18:08:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-25 18:14:48]

Description was changed from

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Add command buffer function glScheduleCALayerFilterEffectsCHROMIUM.

The function allows the client to send a vector of filter effects to apply to
the next layer scheduled with glScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/744e856254e98e5cacf311d5ee989e2fa5cb3252
Cr-Commit-Position: refs/heads/master@{#407513}
==========

[commit-bot: I haz the power, 2016-07-25 18:14:49]

Patchset 5 (id:??) landed as
https://crrev.com/744e856254e98e5cacf311d5ee989e2fa5cb3252
Cr-Commit-Position: refs/heads/master@{#407513}

[piman, 2016-07-25 19:51:10]

lgtm