Implement filter effects in Core Animation using CAFilters.

Implement filter effects in Core Animation using CAFilters.

Filter effects are converted into CAFilters, which are applied to the CALayer.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3bf2141da52df2a38288455c142e5dd164253130
Cr-Commit-Position: refs/heads/master@{#407951}

[erikchen, 2016-07-26 19:02:14]

Description was changed from

==========
Implement filter effects in Core Animation using CAFilters.

BUG=581526
==========

to

==========
Implement filter effects in Core Animation using CAFilters.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-07-26 19:49:50]

Description was changed from

==========
Implement filter effects in Core Animation using CAFilters.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement filter effects in Core Animation using CAFilters.

Filter effects are converted into CAFilters, which are applied to the CALayer.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-07-26 19:49:51]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:50:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-07-26 20:31:38]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org, piman@chromium.org

[erikchen, 2016-07-26 20:31:39]

piman: Please review gpu/
ccameron: Please review ui/

[piman, 2016-07-26 20:42:43]

lgtm

https://codereview.chromium.org/2186693002/diff/40001/ui/gl/ca_renderer_layer...
File ui/gl/ca_renderer_layer_params.h (right):

https://codereview.chromium.org/2186693002/diff/40001/ui/gl/ca_renderer_layer...
ui/gl/ca_renderer_layer_params.h:83: const
ui::CARendererLayerParams::FilterEffect& b);
Why the need for this one? ADL should find FilterEffect.operator== ?

[commit-bot: I haz the power, 2016-07-26 20:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 20:53:10]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-07-26 21:33:31]

lgtm 2

[erikchen, 2016-07-26 21:49:26]

https://codereview.chromium.org/2186693002/diff/40001/ui/gl/ca_renderer_layer...
File ui/gl/ca_renderer_layer_params.h (right):

https://codereview.chromium.org/2186693002/diff/40001/ui/gl/ca_renderer_layer...
ui/gl/ca_renderer_layer_params.h:83: const
ui::CARendererLayerParams::FilterEffect& b);
On 2016/07/26 20:42:43, piman - slow reviews until 8-8 wrote:
> Why the need for this one? ADL should find FilterEffect.operator== ?

I thought I needed this for std::vector<T>::operator==, but I removed it and no
longer see any problems.

[erikchen, 2016-07-26 21:49:30]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-26 21:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2186693002/#ps60001
(title: "Comments from piman.")

[commit-bot: I haz the power, 2016-07-26 21:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 23:03:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 23:05:18]

Description was changed from

==========
Implement filter effects in Core Animation using CAFilters.

Filter effects are converted into CAFilters, which are applied to the CALayer.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement filter effects in Core Animation using CAFilters.

Filter effects are converted into CAFilters, which are applied to the CALayer.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3bf2141da52df2a38288455c142e5dd164253130
Cr-Commit-Position: refs/heads/master@{#407951}
==========

[commit-bot: I haz the power, 2016-07-26 23:05:19]

Patchset 4 (id:??) landed as
https://crrev.com/3bf2141da52df2a38288455c142e5dd164253130
Cr-Commit-Position: refs/heads/master@{#407951}

[erikchen, 2016-08-04 00:14:12]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2208943002/ by erikchen@chromium.org.

The reason for reverting is: The new implementation for filter effects in the CA
compositor doesn't rely on CA filters, which are fundamentally flawed.

See https://bugs.chromium.org/p/chromium/issues/detail?id=581526#c29 for more
details..