Dismissing suggestion window upon receiving BACK key.

Dismissing suggestion window upon receiving BACK key.

Currently Tab is consuming the device BACK key even when suggestion window
is visible and doing page navigation instead of dismissing suggestion
window. Added changes to consume BACK key at suggestion window, so that
it can consume BACK key and execute respective actions.

BUG=630633
Committed: https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d
Cr-Commit-Position: refs/heads/master@{#407703}

[AKV, 2016-07-22 15:21:14]

ajith.v@chromium.org changed reviewers:
+ tedchoc@chromium.org, yfriedman@chromium.org

[AKV, 2016-07-22 15:21:15]

PTAL!

[Ted C, 2016-07-22 22:37:20]

On 2016/07/22 15:21:15, AKV wrote:
> PTAL!

I have an alternate proposal here:
https://codereview.chromium.org/2174043002

I'd prefer to keep the logic in a single place if possible.

Or with your patch, could we remove the logic in UrlBar?  That
would also be fine with me.

[AKV, 2016-07-23 05:41:33]

On 2016/07/22 22:37:20, Ted C wrote:
> On 2016/07/22 15:21:15, AKV wrote:
> > PTAL!
> 
> I have an alternate proposal here:
> https://codereview.chromium.org/2174043002
> 
> I'd prefer to keep the logic in a single place if possible.
> 
> Or with your patch, could we remove the logic in UrlBar?  That
> would also be fine with me.

Thank you Ted for informing about your patch. Yes, UrlBar onKey() is dead code
even before this patch, after I replaced onKeyPreIme() with onKey(). So I am
fine with removing onKey() from UrlBar.java (Because, final code execution,
which takes care of removing Suggestion window is happening in
LocationBarLayout, so we can remove processing at UrlBar).

[AKV, 2016-07-25 09:05:54]

PTAL!

[Ted C, 2016-07-25 23:34:23]

lgtm

[AKV, 2016-07-26 03:45:10]

The CQ bit was checked by ajith.v@chromium.org

[commit-bot: I haz the power, 2016-07-26 03:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:12:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 04:15:01]

Description was changed from

==========
Dismissing suggestion window upon receiving BACK key.

Currently Tab is consuming the device BACK key even when suggestion window
is visible and doing page navigation instead of dismissing suggestion
window. Added changes to consume BACK key at suggestion window, so that
it can consume BACK key and execute respective actions.

BUG=630633
==========

to

==========
Dismissing suggestion window upon receiving BACK key.

Currently Tab is consuming the device BACK key even when suggestion window
is visible and doing page navigation instead of dismissing suggestion
window. Added changes to consume BACK key at suggestion window, so that
it can consume BACK key and execute respective actions.

BUG=630633

Committed: https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d
Cr-Commit-Position: refs/heads/master@{#407703}
==========

[commit-bot: I haz the power, 2016-07-26 04:15:02]

Patchset 2 (id:??) landed as
https://crrev.com/5a24ca6788c61a71cb28089d4b2ab80e506cc50d
Cr-Commit-Position: refs/heads/master@{#407703}