Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2440643002: Remove TabModelSelector's dependency on ChromeFullscreenManager. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, dominickn+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TabModelSelector's dependency on ChromeFullscreenManager. ChromeFullscreenManager will now register and listen for updates internally and avoids the prior cyclical dependency. This also fixes a bug introduced in: https://codereview.chromium.org/2414913004 In that, we were not clearing the reference to Tab when reparenting and then there were two fullscreen managers listening for updates. BUG=656939 Committed: https://crrev.com/820a95b0b81d33e42712f9198c215f703412e1a1 Cr-Commit-Position: refs/heads/master@{#426935}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : file move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -234 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 5 chunks +34 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java View 5 chunks +1 line, -9 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserver.java View 3 chunks +21 lines, -37 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java View 3 chunks +14 lines, -39 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java View 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java View 3 chunks +6 lines, -7 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorObserverTestBase.java View 1 chunk +138 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java View 1 chunk +1 line, -92 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerTest.java View 3 chunks +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
Ted C
Here is the change that fixes the ChromeFullscreenManager dependency and should allow CCT to initialize ...
4 years, 2 months ago (2016-10-20 00:04:43 UTC) #3
Ted C
The dependent change landed and I rebased this, so this should be good to be ...
4 years, 2 months ago (2016-10-20 22:46:49 UTC) #4
Yusuf
lgtm
4 years, 2 months ago (2016-10-21 20:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440643002/40001
4 years, 2 months ago (2016-10-21 20:23:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/165782)
4 years, 2 months ago (2016-10-21 22:01:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440643002/60001
4 years, 2 months ago (2016-10-21 22:13:13 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-22 00:29:54 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-22 00:32:46 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/820a95b0b81d33e42712f9198c215f703412e1a1
Cr-Commit-Position: refs/heads/master@{#426935}

Powered by Google App Engine
This is Rietveld 408576698