Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

Issue 2174633004: Dismissing suggestion window upon receiving BACK key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed key processing from UrlBar Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
index 45dae29e8e5065e339be25b7368e366fd0a49970..ef895eef94f325ae567280d4ffcc55d3b25ac76a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
@@ -20,10 +20,8 @@ import android.text.TextUtils;
import android.text.style.ReplacementSpan;
import android.util.AttributeSet;
import android.view.GestureDetector;
-import android.view.KeyEvent;
import android.view.MotionEvent;
import android.view.View;
-import android.view.View.OnKeyListener;
import android.view.accessibility.AccessibilityEvent;
import android.view.accessibility.AccessibilityManager;
import android.view.accessibility.AccessibilityNodeInfo;
@@ -52,7 +50,7 @@ import java.net.URL;
/**
* The URL text entry view for the Omnibox.
*/
-public class UrlBar extends VerticallyFixedEditText implements OnKeyListener {
+public class UrlBar extends VerticallyFixedEditText {
private static final String TAG = "UrlBar";
// TextView becomes very slow on long strings, so we limit maximum length
@@ -166,11 +164,6 @@ public class UrlBar extends VerticallyFixedEditText implements OnKeyListener {
void onTextChangedForAutocomplete(boolean textDeleted);
/**
- * Called to notify that back key has been pressed while the focus in on the url bar.
- */
- void backKeyPressed();
-
- /**
* @return Whether the light security theme should be used.
*/
boolean shouldEmphasizeHttpsScheme();
@@ -225,7 +218,6 @@ public class UrlBar extends VerticallyFixedEditText implements OnKeyListener {
mAccessibilityManager =
(AccessibilityManager) context.getSystemService(Context.ACCESSIBILITY_SERVICE);
- setOnKeyListener(this);
}
/**
@@ -509,24 +501,6 @@ public class UrlBar extends VerticallyFixedEditText implements OnKeyListener {
}
@Override
- public boolean onKey(View v, int keyCode, KeyEvent event) {
- if (keyCode == KeyEvent.KEYCODE_BACK) {
- if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {
- // Tell the framework to start tracking this event.
- getKeyDispatcherState().startTracking(event, this);
- return true;
- } else if (event.getAction() == KeyEvent.ACTION_UP) {
- getKeyDispatcherState().handleUpEvent(event);
- if (event.isTracking() && !event.isCanceled()) {
- mUrlBarDelegate.backKeyPressed();
- return true;
- }
- }
- }
- return false;
- }
-
- @Override
public boolean onTouchEvent(MotionEvent event) {
if (!mFocused) {
mGestureDetector.onTouchEvent(event);

Powered by Google App Engine
This is Rietveld 408576698