Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2174633004: Dismissing suggestion window upon receiving BACK key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed key processing from UrlBar Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index cd4dd23c1827bc3ab5cdb522f3fde8e908e27848..fc75a2871ae572279bf448f05347cab297744f24 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -321,8 +321,19 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
});
}
return true;
+ } else if (keyCode == KeyEvent.KEYCODE_BACK) {
+ if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {
+ // Tell the framework to start tracking this event.
+ getKeyDispatcherState().startTracking(event, this);
+ return true;
+ } else if (event.getAction() == KeyEvent.ACTION_UP) {
+ getKeyDispatcherState().handleUpEvent(event);
+ if (event.isTracking() && !event.isCanceled()) {
+ backKeyPressed();
+ return true;
+ }
+ }
}
-
return false;
}
@@ -1952,8 +1963,7 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
}
}
- @Override
- public void backKeyPressed() {
+ private void backKeyPressed() {
hideSuggestions();
UiUtils.hideKeyboard(mUrlBar);
// Revert the URL to match the current page.
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698