PlzNavigate: Support renderer-side failed navigations

PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c286509b7eab9543a8d85dc3061eb6fc52babb34
Cr-Commit-Position: refs/heads/master@{#414384}

[blundell, 2016-07-22 12:32:20]

Description was changed from

==========
PlzNavigate: Support renderer-side failed navigations
==========

to

==========
PlzNavigate: Support renderer-side failed navigations
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[blundell, 2016-07-22 12:34:16]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 12:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 12:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 12:40:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[blundell, 2016-07-29 14:42:37]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 14:42:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:54:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 15:54:55]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-08-16 08:03:54]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 08:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 09:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 09:13:46]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-08-17 14:36:52]

Description was changed from

==========
PlzNavigate: Support renderer-side failed navigations
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
==========

[blundell, 2016-08-17 14:41:41]

blundell@chromium.org changed reviewers:
+ clamy@chromium.org

[blundell, 2016-08-17 14:47:59]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:48:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:44:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[clamy, 2016-08-18 12:07:08]

On 2016/08/17 14:41:42, blundell wrote:

Thanks! It looks mostly good, but could you also
NavigatorImpl::DidFailProvisionalLoadWithError so that we discard the pending
entry in the PlzNavigate test as well (note this may cause some issue with the
content_unittests).

[blundell, 2016-08-18 12:23:57]

Description was changed from

==========
PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
==========

to

==========
PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[blundell, 2016-08-18 12:35:01]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 12:35:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 14:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 14:30:04]

Dry run: Exceeded global retry quota

[blundell, 2016-08-19 07:19:57]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:20:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 07:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 07:23:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-08-19 07:52:19]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 10:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 10:12:19]

Dry run: Exceeded global retry quota

[blundell, 2016-08-22 14:35:21]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 14:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 17:09:58]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-08-23 09:35:54]

On 2016/08/18 12:07:08, clamy wrote:
> On 2016/08/17 14:41:42, blundell wrote:
> 
> Thanks! It looks mostly good, but could you also
> NavigatorImpl::DidFailProvisionalLoadWithError so that we discard the pending
> entry in the PlzNavigate test as well (note this may cause some issue with the
> content_unittests).

Done (turned out this didn't cause any new content_unittests failures, which you
can see by looking at the PlzNavigate trybot results on PS7).

[clamy, 2016-08-23 21:40:16]

Thanks! Lgtm

[blundell, 2016-08-24 07:57:25]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-08-24 07:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 11:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 11:14:45]

Failed to apply patch for
testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:
While running git apply --index -3 -p1;
  error: patch failed:
testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:98
  Falling back to three-way merge...
  Applied patch to
'testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter'
with conflicts.
  U testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

Patch:      
testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
Index:
testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
diff --git
a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
index
917f15969300c0503bd3e7a2e366d87f5a671272..b2d63577ba47c3361e106a7c1f4a714131a37c15
100644
---
a/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
+++
b/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter
@@ -50,6 +50,16 @@
 -DevToolsPixelOutputTests.TestScreenshotRecording
 -DevToolsSanityTest.TestNetworkRawHeadersText
 -DevToolsReattachAfterCrashTest.*
+-DnsProbeBrowserTest.CorrectionsDisabled
+-DnsProbeBrowserTest.CorrectionsLoadStoppedSlowProbe
+-DnsProbeBrowserTest.CorrectionsLoadStopped
+-DnsProbeBrowserTest.Incognito
+-DnsProbeBrowserTest.NoInternetProbeResultWithBrokenCorrections
+-DnsProbeBrowserTest.NoInternetProbeResultWithSlowBrokenCorrections
+-DnsProbeBrowserTest.NxdomainProbeResultWithWorkingCorrections
+-DnsProbeBrowserTest.NxdomainProbeResultWithWorkingSlowCorrections
+-DnsProbeBrowserTest.ProbesDisabled
+-DnsProbeBrowserTest.SyncFailureWithBrokenCorrections
 -DomDistillerTabUtilsBrowserTest.TestDistillIntoWebContents
 -DomDistillerTabUtilsBrowserTest.TestSwapWebContents
 -DomDistillerViewerSourceBrowserTest.DistillerJavaScriptExposed
@@ -72,7 +82,9 @@
 -ErrorPageAutoReloadTest.AutoReload
 -ErrorPageAutoReloadTest.IgnoresSamePageNavigation
 -ErrorPageAutoReloadTest.ManualReloadNotSuppressed
+-ErrorPageNavigationCorrectionsFailTest.FetchCorrectionsFails
 -ErrorPageTest.DNSError*
+-ErrorPageTest.IFrameDNSError_JavaScript
 -ErrorPageTest.StaleCacheStatus
 -ExecuteScriptApiTest.ExecuteScriptByFrameId
 -ExecuteScriptApiTest.FrameWithHttp204
@@ -98,7 +110,10 @@
 -FirstRunMasterPrefsImportNothing.ImportNothingAndShowNewTabPage
 -InlineLoginUISafeIframeBrowserTest.ConfirmationRequiredForNonsecureSignin
 -InputImeApiTest*
+-InProcessBrowserTest.ExternalConnectionFail
 -IsolatedAppTest.CookieIsolation
+-LaunchWebAuthFlowFunctionTest.InteractiveFirstNavigationSuccess
+-LaunchWebAuthFlowFunctionTest.NonInteractiveSuccess
 -LoadTimingBrowserTest.Basic
 -LoadTimingBrowserTest.EverythingAtOnce
 -LoadTimingBrowserTest.Integration

[blundell, 2016-08-24 12:09:50]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-08-24 12:09:50]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org
Link to the patchset: https://codereview.chromium.org/2173803003/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-24 12:10:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:40:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:40:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[blundell, 2016-08-25 06:48:39]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-08-25 06:49:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 10:49:51]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-25 10:51:28]

Description was changed from

==========
PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: Support renderer-side failed navigations

In PlzNavigate, RenderFrameHostImpl currently requires that when it
gets a DidFailProvisionalLoad IPC, it has previously seen a net error.
This requirement holds for browser-side failed navigations but not for
renderer-side failed navigations. The latter fact causes some layout
tests to fail.

The DidFailProvisionalLoad IPC is scheduled for removal once all
WebContentsObservers have moved to listening for DidFinishNavigation().
As a step in the process (and to move layout tests towards being green
in PlzNavigate), this CL eliminates the sending of this IPC for
browser-side failed navigations. It additionally eliminates the
assertion in RFHI that it has already seen a network error when
receiving a DidFailProvisionalLoad IPC (since it will now be seeing
that IPC only for renderer-side failed navigations).

This CL also updates the browser_tests PlzNavigate filter for the tests
that are now failing because they rely on listening for the deprecated
WCO callbacks from browser-side failed navigations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c286509b7eab9543a8d85dc3061eb6fc52babb34
Cr-Commit-Position: refs/heads/master@{#414384}
==========

[commit-bot: I haz the power, 2016-08-25 10:51:29]

Patchset 9 (id:??) landed as
https://crrev.com/c286509b7eab9543a8d85dc3061eb6fc52babb34
Cr-Commit-Position: refs/heads/master@{#414384}