Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2173803003: PlzNavigate: Support renderer-side failed navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plznavigate_notification_done
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 1794aaa71fcb5af4caa22cb3e05cb35ac6285d80..d6ee3d333518761ebd9561c4d136a77be443741a 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1020,20 +1020,9 @@ void RenderFrameHostImpl::OnDidFailProvisionalLoadWithError(
// TODO(clamy): Kill the renderer with RFH_FAIL_PROVISIONAL_LOAD_NO_HANDLE and
// return early if navigation_handle_ is null, once we prevent that case from
// happening in practice.
- if (IsBrowserSideNavigationEnabled() && navigation_handle_ &&
- navigation_handle_->GetNetErrorCode() == net::OK) {
- // The renderer should not be sending this message unless asked to commit
- // an error page.
- // TODO(clamy): Stop sending DidFailProvisionalLoad IPCs at all when enough
- // observers have moved to DidFinishNavigation.
- bad_message::ReceivedBadMessage(
- GetProcess(), bad_message::RFH_FAIL_PROVISIONAL_LOAD_NO_ERROR);
- return;
- }
// Update the error code in the NavigationHandle of the navigation.
- // PlzNavigate: this has already done in NavigationRequest::OnRequestFailed.
- if (!IsBrowserSideNavigationEnabled() && navigation_handle_) {
+ if (navigation_handle_) {
navigation_handle_->set_net_error_code(
static_cast<net::Error>(params.error_code));
}
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698