Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2173803003: PlzNavigate: Support renderer-side failed navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plznavigate_notification_done
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ccf721b424fc7f0f44cfdff8a2071c4ac10c213e..694b0048a59f04a3637a228a7ae552208ace50d7 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4865,18 +4865,12 @@ void RenderFrameImpl::OnFailedNavigation(
pending_navigation_params_.reset(new NavigationParams(
common_params, StartNavigationParams(), request_params));
- // Inform the browser of the start of the provisional load. This is needed so
- // that the load is properly tracked by the WebNavigation API.
- Send(new FrameHostMsg_DidStartProvisionalLoad(
- routing_id_, common_params.url, common_params.navigation_start));
-
// Send the provisional load failure.
blink::WebURLError error =
CreateWebURLError(common_params.url, has_stale_copy_in_cache, error_code);
WebURLRequest failed_request = CreateURLRequestForNavigation(
common_params, std::unique_ptr<StreamOverrideParameters>(),
frame_->isViewSourceModeEnabled());
- SendFailedProvisionalLoad(failed_request, error, frame_);
if (!ShouldDisplayErrorPageForFailedLoad(error_code, common_params.url)) {
// The browser expects this frame to be loading an error page. Inform it

Powered by Google App Engine
This is Rietveld 408576698