Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2278563002: PlzNavigate: Triage renderer-initiated failed navigation tests (Closed)

Created:
4 years, 4 months ago by blundell
Modified:
4 years, 3 months ago
Reviewers:
clamy
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@renderer_side_failed_navigation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Triage renderer-initiated failed navigation tests These tests fail due to WebFrameClient having a difference sequence of callbacks, which is itself due to the fact that in PlzNavigate, the navigation failure is detected in the browser. BUG=640631 Committed: https://crrev.com/76f7fed1ec182373a0cde7bb2485ed4636f4b62f Cr-Commit-Position: refs/heads/master@{#414410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
blundell
4 years, 4 months ago (2016-08-24 15:44:07 UTC) #2
clamy
Thanks! Lgtm.
4 years, 4 months ago (2016-08-24 23:15:33 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2173803003 Patch 160001). Please resolve the dependency and ...
4 years, 3 months ago (2016-08-25 06:48:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278563002/1
4 years, 3 months ago (2016-08-25 11:32:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 12:56:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:57:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76f7fed1ec182373a0cde7bb2485ed4636f4b62f
Cr-Commit-Position: refs/heads/master@{#414410}

Powered by Google App Engine
This is Rietveld 408576698