Use smart pointers for class owned pointers

Use smart pointers for class owned pointers

For all classes under /fpdfsdk, use smart pointer to replace
raw pointer type for class owned member variables so that memory
management will be easier.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/2d5b020304e8a9aa8afeb632c61daa7ece87e36d

[Wei Li, 2016-07-22 22:23:10]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-07-22 22:23:39]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 22:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:32:54]

Dry run: Try jobs failed on following builders:
  mac_xfa_rel_gyp on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa_rel_gyp...)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Wei Li, 2016-08-02 22:19:34]

Patchset #3 (id:60001) has been deleted

[Wei Li, 2016-08-02 22:20:06]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:20:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 22:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 22:32:41]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-02 22:35:58]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-02 22:35:59]

pls review, thanks

[Lei Zhang, 2016-08-02 22:54:00]

lgtm

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/formfiller/cffl...
File fpdfsdk/formfiller/cffl_iformfiller.h (right):

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/formfiller/cffl...
fpdfsdk/formfiller/cffl_iformfiller.h:10: #include <memory>
alphabetical order

[dsinclair, 2016-08-03 12:47:56]

lgtm w/ question.

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/pdfwindow/PWL_F...
File fpdfsdk/pdfwindow/PWL_FontMap.h (right):

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/pdfwindow/PWL_F...
fpdfsdk/pdfwindow/PWL_FontMap.h:56: using CharsetFontMap = FPDF_CharsetFontMap;
Is this useful? Seems like it just saves 5 chars but hides the implementation
class?

[Wei Li, 2016-08-03 17:18:24]

Patchset #4 (id:100001) has been deleted

[Wei Li, 2016-08-03 17:24:28]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 17:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 17:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 17:36:56]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-03 17:54:47]

thanks

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/formfiller/cffl...
File fpdfsdk/formfiller/cffl_iformfiller.h (right):

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/formfiller/cffl...
fpdfsdk/formfiller/cffl_iformfiller.h:10: #include <memory>
On 2016/08/02 22:54:00, Lei Zhang wrote:
> alphabetical order

Done.

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/pdfwindow/PWL_F...
File fpdfsdk/pdfwindow/PWL_FontMap.h (right):

https://codereview.chromium.org/2173253002/diff/80001/fpdfsdk/pdfwindow/PWL_F...
fpdfsdk/pdfwindow/PWL_FontMap.h:56: using CharsetFontMap = FPDF_CharsetFontMap;
On 2016/08/03 12:47:55, dsinclair wrote:
> Is this useful? Seems like it just saves 5 chars but hides the implementation
> class?

Removed it.

[Wei Li, 2016-08-03 18:06:31]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-03 18:06:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2173253002/#ps120001
(title: "address comments")

[commit-bot: I haz the power, 2016-08-03 18:06:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:06:52]

Description was changed from

==========
Use smart pointers for class owned pointers

For all classes under /fpdfsdk, use smart pointer to replace
raw pointer type for class owned member variables so that memory
management will be easier.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers

For all classes under /fpdfsdk, use smart pointer to replace
raw pointer type for class owned member variables so that memory
management will be easier.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/2d5b020304e8a9aa8afeb632c61daa7ece87...
==========

[commit-bot: I haz the power, 2016-08-03 18:06:53]

Committed patchset #4 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/2d5b020304e8a9aa8afeb632c61daa7ece87...