Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: fpdfsdk/pdfwindow/PWL_Wnd.cpp

Issue 2173253002: Use smart pointers for class owned pointers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/pdfwindow/PWL_Wnd.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "fpdfsdk/pdfwindow/PWL_ScrollBar.h" 9 #include "fpdfsdk/pdfwindow/PWL_ScrollBar.h"
10 #include "fpdfsdk/pdfwindow/PWL_Utils.h" 10 #include "fpdfsdk/pdfwindow/PWL_Utils.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 void CPWL_Timer::TimerProc(int32_t idEvent) { 73 void CPWL_Timer::TimerProc(int32_t idEvent) {
74 auto it = GetPWLTimeMap().find(idEvent); 74 auto it = GetPWLTimeMap().find(idEvent);
75 if (it == GetPWLTimeMap().end()) 75 if (it == GetPWLTimeMap().end())
76 return; 76 return;
77 77
78 CPWL_Timer* pTimer = it->second; 78 CPWL_Timer* pTimer = it->second;
79 if (pTimer->m_pAttached) 79 if (pTimer->m_pAttached)
80 pTimer->m_pAttached->TimerProc(); 80 pTimer->m_pAttached->TimerProc();
81 } 81 }
82 82
83 CPWL_TimerHandler::CPWL_TimerHandler() : m_pTimer(nullptr) {} 83 CPWL_TimerHandler::CPWL_TimerHandler() {}
84 84
85 CPWL_TimerHandler::~CPWL_TimerHandler() { 85 CPWL_TimerHandler::~CPWL_TimerHandler() {}
86 delete m_pTimer;
87 }
88 86
89 void CPWL_TimerHandler::BeginTimer(int32_t nElapse) { 87 void CPWL_TimerHandler::BeginTimer(int32_t nElapse) {
90 if (!m_pTimer) 88 if (!m_pTimer)
91 m_pTimer = new CPWL_Timer(this, GetSystemHandler()); 89 m_pTimer.reset(new CPWL_Timer(this, GetSystemHandler()));
92 90
93 if (m_pTimer) 91 if (m_pTimer)
94 m_pTimer->SetPWLTimer(nElapse); 92 m_pTimer->SetPWLTimer(nElapse);
95 } 93 }
96 94
97 void CPWL_TimerHandler::EndTimer() { 95 void CPWL_TimerHandler::EndTimer() {
98 if (m_pTimer) 96 if (m_pTimer)
99 m_pTimer->KillPWLTimer(); 97 m_pTimer->KillPWLTimer();
100 } 98 }
101 99
(...skipping 937 matching lines...) Expand 10 before | Expand all | Expand 10 after
1039 return FALSE; 1037 return FALSE;
1040 } 1038 }
1041 1039
1042 FX_BOOL CPWL_Wnd::IsALTpressed(uint32_t nFlag) const { 1040 FX_BOOL CPWL_Wnd::IsALTpressed(uint32_t nFlag) const {
1043 if (CFX_SystemHandler* pSystemHandler = GetSystemHandler()) { 1041 if (CFX_SystemHandler* pSystemHandler = GetSystemHandler()) {
1044 return pSystemHandler->IsALTKeyDown(nFlag); 1042 return pSystemHandler->IsALTKeyDown(nFlag);
1045 } 1043 }
1046 1044
1047 return FALSE; 1045 return FALSE;
1048 } 1046 }
OLDNEW
« no previous file with comments | « fpdfsdk/pdfwindow/PWL_Wnd.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698