fpdfsdk/formfiller/cffl_listbox.h - Issue 2173253002: Use smart pointers for class owned pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cffl_listbox.h

Issue 2173253002: Use smart pointers for class owned pointers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cffl_listbox.h

diff --git a/fpdfsdk/formfiller/cffl_listbox.h b/fpdfsdk/formfiller/cffl_listbox.h

index 43fbab664213e809567a73fc5faa137bd2de60f2..4d1f64f113e3c0234c750142eafdb14abf1c9359 100644

--- a/fpdfsdk/formfiller/cffl_listbox.h

+++ b/fpdfsdk/formfiller/cffl_listbox.h

@@ -7,6 +7,7 @@

#ifndef FPDFSDK_FORMFILLER_CFFL_LISTBOX_H_

#define FPDFSDK_FORMFILLER_CFFL_LISTBOX_H_

+#include <memory>

#include <set>

#include "fpdfsdk/formfiller/cffl_formfiller.h"

@@ -37,7 +38,7 @@ class CFFL_ListBox : public CFFL_FormFiller {

FX_BOOL bRestoreValue) override;

private:

- CBA_FontMap* m_pFontMap;

+ std::unique_ptr<CBA_FontMap> m_pFontMap;

std::set<int> m_OriginSelections;

CFX_ArrayTemplate<int> m_State;

};

« no previous file with comments | « fpdfsdk/formfiller/cffl_iformfiller.cpp ('k') | fpdfsdk/formfiller/cffl_listbox.cpp » ('j') | no next file with comments »