fpdfsdk/include/fsdk_mgr.h - Issue 2173253002: Use smart pointers for class owned pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/fsdk_mgr.h

Issue 2173253002: Use smart pointers for class owned pointers (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/fsdk_mgr.h

diff --git a/fpdfsdk/include/fsdk_mgr.h b/fpdfsdk/include/fsdk_mgr.h

index b87c982cc16a3aee9c5bcf984eb5c349bea5b2d8..1c180db57f12975e02a5f107f51ee9fa9ece04f0 100644

--- a/fpdfsdk/include/fsdk_mgr.h

+++ b/fpdfsdk/include/fsdk_mgr.h

@@ -619,7 +619,7 @@ class CPDFSDK_PageView final : public CPDF_Page::View {

UnderlyingPageType* const m_page;

std::unique_ptr<CPDF_AnnotList> m_pAnnotList;

std::vector<CPDFSDK_Annot*> m_fxAnnotArray;

- CPDFSDK_Document* m_pSDKDoc;

+ CPDFSDK_Document* const m_pSDKDoc;

#ifdef PDF_ENABLE_XFA

CPDFSDK_Annot* m_CaptureWidget;

#else // PDF_ENABLE_XFA

« no previous file with comments | « fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h ('k') | fpdfsdk/javascript/cjs_context.h » ('j') | no next file with comments »