Migrate addMessageToConsole API to WebFrameClient.

Migrate addMessageToConsole API to WebFrameClient.

This adds the console message APIs to WebFrameClient.

BUG=304341
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170549

[mkosiba (inactive), 2014-03-28 18:46:50]

PTAL. The chrome-side of this CL is https://codereview.chromium.org/217183004

[jochen (gone - plz use gerrit), 2014-03-31 10:03:05]

lgtm with nits

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:377: WebFrameImpl* webframe =
m_webView->mainFrameImpl();
would be nice if this was the frame the message was created in, no?

https://codereview.chromium.org/217283004/diff/1/public/web/WebFrameClient.h
File public/web/WebFrameClient.h (right):

https://codereview.chromium.org/217283004/diff/1/public/web/WebFrameClient.h#...
public/web/WebFrameClient.h:158: const WebConsoleMessage&, const WebString&
sourceName, unsigned sourceLine, const WebString& stackTrace) { }
all in one line plz

[mkosiba (inactive), 2014-03-31 11:21:55]

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:377: WebFrameImpl* webframe =
m_webView->mainFrameImpl();
On 2014/03/31 10:03:05, jochen wrote:
> would be nice if this was the frame the message was created in, no?

mm.. the PageConsole is a bit tricky. What do I do with the FrameHost?
The right thing seems to be to have addMessageToConsole take a FrameHost
as a param (rather than a LocalFrame) and use frameHost->page()->mainFrame()
here. Going through page() defeats the purpose though. Should FrameHost
have some sort of 'rootFrame' method?

[jochen (gone - plz use gerrit), 2014-03-31 11:25:50]

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:377: WebFrameImpl* webframe =
m_webView->mainFrameImpl();
On 2014/03/31 11:21:55, mkosiba wrote:
> On 2014/03/31 10:03:05, jochen wrote:
> > would be nice if this was the frame the message was created in, no?
> 
> mm.. the PageConsole is a bit tricky. What do I do with the FrameHost?
> The right thing seems to be to have addMessageToConsole take a FrameHost
> as a param (rather than a LocalFrame) and use frameHost->page()->mainFrame()
> here. Going through page() defeats the purpose though. Should FrameHost
> have some sort of 'rootFrame' method?

why would the rootFrame be the right frame?

I mean, the old behavior was using the webview, however, if we go down to a
per-frame level, why not use exactly the frame that triggered the message?

[mkosiba (inactive), 2014-03-31 14:46:35]

On 2014/03/31 11:25:50, jochen wrote:
>
https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl.cpp
> File Source/web/ChromeClientImpl.cpp (right):
> 
>
https://codereview.chromium.org/217283004/diff/1/Source/web/ChromeClientImpl....
> Source/web/ChromeClientImpl.cpp:377: WebFrameImpl* webframe =
> m_webView->mainFrameImpl();
> On 2014/03/31 11:21:55, mkosiba wrote:
> > On 2014/03/31 10:03:05, jochen wrote:
> > > would be nice if this was the frame the message was created in, no?
> > 
> > mm.. the PageConsole is a bit tricky. What do I do with the FrameHost?
> > The right thing seems to be to have addMessageToConsole take a FrameHost
> > as a param (rather than a LocalFrame) and use frameHost->page()->mainFrame()
> > here. Going through page() defeats the purpose though. Should FrameHost
> > have some sort of 'rootFrame' method?
> 
> why would the rootFrame be the right frame?
> 
> I mean, the old behavior was using the webview, however, if we go down to a
> per-frame level, why not use exactly the frame that triggered the message?

so I started moving the PageConsole to a FrameConsole - it's a w.i.p snapshot
and doesn't compile yet but could you let me know whether I'm going in the
right direction?

[mkosiba (inactive), 2014-03-31 16:15:24]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-03-31 16:15:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/217283004/40001

[commit-bot: I haz the power, 2014-03-31 16:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 16:29:35]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[mkosiba (inactive), 2014-04-01 11:12:04]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-04-01 11:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/217283004/40001

[commit-bot: I haz the power, 2014-04-01 11:36:25]

Change committed as 170549