Migrate addMessageToConsole API to WebFrameClient.

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 347 matching lines @@
     return m_menubarVisible;
 }
 
 void ChromeClientImpl::setResizable(bool value)
 {
     m_resizable = value;
 }
 
 bool ChromeClientImpl::shouldReportDetailedMessageForSource(const String& url)
 {
-    return m_webView->client() && m_webView->client()->shouldReportDetailedMessageForSource(url);
+    WebFrameImpl* webframe = m_webView->mainFrameImpl();
+    // TODO(mkosiba): remove once Chrome side is updated.
+    bool shouldReport = m_webView->client() && m_webView->client()->shouldReportDetailedMessageForSource(url);
+    shouldReport &= webframe->client() && webframe->client()->shouldReportDetailedMessageForSource(url);
+    return shouldReport;
 }
 
 void ChromeClientImpl::addMessageToConsole(MessageSource source, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID, const String& stackTrace)
 {
+    WebFrameImpl* webframe = m_webView->mainFrameImpl();

[jochen (gone - plz use gerrit), 2014/03/31 10:03:05]

would be nice if this was the frame the message was created in, no?

[mkosiba (inactive), 2014/03/31 11:21:55]

mm.. the PageConsole is a bit tricky. What do I do with the FrameHost?
The right thing seems to be to have addMessageToConsole take a FrameHost
as a param (rather than a LocalFrame) and use frameHost->page()->mainFrame()
here. Going through page() defeats the purpose though. Should FrameHost
have some sort of 'rootFrame' method?

[jochen (gone - plz use gerrit), 2014/03/31 11:25:51]

why would the rootFrame be the right frame?

I mean, the old behavior was using the webview, however, if we go down to a
per-frame level, why not use exactly the frame that triggered the message?

+    if (webframe->client()) {
+        webframe->client()->didAddMessageToConsole(
+            WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
+            sourceID,
+            lineNumber,
+            stackTrace);
+    }
+    // TODO(mkosiba): remove once Chrome side is updated.
     if (m_webView->client()) {
         m_webView->client()->didAddMessageToConsole(
             WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
             sourceID,
             lineNumber,
             stackTrace);
     }
 }
 
 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel()
@@ skipping 578 matching lines @@
 {
     return static_cast<NavigatorContentUtilsClient::CustomHandlersState>(m_webView->client()->isProtocolHandlerRegistered(scheme, baseURL, url));
 }
 
 void NavigatorContentUtilsClientImpl::unregisterProtocolHandler(const String& scheme, const WebCore::KURL& baseURL, const WebCore::KURL& url)
 {
     m_webView->client()->unregisterProtocolHandler(scheme, baseURL, url);
 }
 
 } // namespace blink