Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: public/web/WebFrameClient.h

Issue 217283004: Migrate addMessageToConsole API to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: back to PS1 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 class WebPlugin; 67 class WebPlugin;
68 class WebRTCPeerConnectionHandler; 68 class WebRTCPeerConnectionHandler;
69 class WebSharedWorker; 69 class WebSharedWorker;
70 class WebSharedWorkerClient; 70 class WebSharedWorkerClient;
71 class WebSocketStreamHandle; 71 class WebSocketStreamHandle;
72 class WebString; 72 class WebString;
73 class WebURL; 73 class WebURL;
74 class WebURLLoader; 74 class WebURLLoader;
75 class WebURLResponse; 75 class WebURLResponse;
76 class WebWorkerPermissionClientProxy; 76 class WebWorkerPermissionClientProxy;
77 struct WebConsoleMessage;
77 struct WebContextMenuData; 78 struct WebContextMenuData;
78 struct WebPluginParams; 79 struct WebPluginParams;
79 struct WebRect; 80 struct WebRect;
80 struct WebSize; 81 struct WebSize;
81 struct WebURLError; 82 struct WebURLError;
82 83
83 class WebFrameClient { 84 class WebFrameClient {
84 public: 85 public:
85 // Factory methods ----------------------------------------------------- 86 // Factory methods -----------------------------------------------------
86 87
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // This frame is about to be closed. This is called after frameDetached, 141 // This frame is about to be closed. This is called after frameDetached,
141 // when the document is being unloaded, due to new one committing. 142 // when the document is being unloaded, due to new one committing.
142 virtual void willClose(WebLocalFrame*) { } 143 virtual void willClose(WebLocalFrame*) { }
143 144
144 // This frame's name has changed. 145 // This frame's name has changed.
145 virtual void didChangeName(WebLocalFrame*, const WebString&) { } 146 virtual void didChangeName(WebLocalFrame*, const WebString&) { }
146 147
147 // Called when a watched CSS selector matches or stops matching. 148 // Called when a watched CSS selector matches or stops matching.
148 virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMa tchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { } 149 virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMa tchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }
149 150
151 // Console messages ----------------------------------------------------
152
153 // Whether or not we should report a detailed message for the given source.
154 virtual bool shouldReportDetailedMessageForSource(const WebString& source) { return false; }
155
156 // A new message was added to the console.
157 virtual void didAddMessageToConsole(const WebConsoleMessage&, const WebStrin g& sourceName, unsigned sourceLine, const WebString& stackTrace) { }
158
150 // Load commands ------------------------------------------------------- 159 // Load commands -------------------------------------------------------
151 160
152 // The client should handle the navigation externally. 161 // The client should handle the navigation externally.
153 virtual void loadURLExternally( 162 virtual void loadURLExternally(
154 WebLocalFrame*, const WebURLRequest&, WebNavigationPolicy) { } 163 WebLocalFrame*, const WebURLRequest&, WebNavigationPolicy) { }
155 virtual void loadURLExternally( 164 virtual void loadURLExternally(
156 WebLocalFrame*, const WebURLRequest&, WebNavigationPolicy, const WebStri ng& downloadName) { } 165 WebLocalFrame*, const WebURLRequest&, WebNavigationPolicy, const WebStri ng& downloadName) { }
157 166
158 167
159 // Navigational queries ------------------------------------------------ 168 // Navigational queries ------------------------------------------------
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 // Send initial drawing parameters to a child frame that is being rendered o ut of process. 424 // Send initial drawing parameters to a child frame that is being rendered o ut of process.
416 virtual void initializeChildFrame(const WebRect& frameRect, float scaleFacto r) { } 425 virtual void initializeChildFrame(const WebRect& frameRect, float scaleFacto r) { }
417 426
418 protected: 427 protected:
419 ~WebFrameClient() { } 428 ~WebFrameClient() { }
420 }; 429 };
421 430
422 } // namespace blink 431 } // namespace blink
423 432
424 #endif 433 #endif
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698